Skip to content

Support Zstd codec in SerializableAvroCodecFactory#32352

Merged
Abacn merged 6 commits intoapache:masterfrom
clairemcginty:avro-io-zstd-codec
Sep 9, 2024
Merged

Support Zstd codec in SerializableAvroCodecFactory#32352
Abacn merged 6 commits intoapache:masterfrom
clairemcginty:avro-io-zstd-codec

Conversation

@clairemcginty
Copy link
Copy Markdown
Contributor

@clairemcginty clairemcginty commented Aug 28, 2024

fixes #32349

Adds support for Zstandard compression in Avro writes

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

clairemcginty
clairemcginty commented Aug 28, 2024
View reviewed changes
.../avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/SerializableAvroCodecFactory.java Outdated
Copy link
Copy Markdown
Contributor Author

@clairemcginty clairemcginty Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: DataFileConstants.ZSTANDARD_CODEC was added in Avro 1.9, so I didn't want to reference it here and break 1.8 users. When Avro 1.8 is dropped it can be used directly

Copy link
Copy Markdown
Contributor

@Abacn Abacn Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late question. zstandard compression level range from negative 7 to 22. This regex does not handle negative, is this a concern?

Copy link
Copy Markdown
Contributor Author

@clairemcginty clairemcginty Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh great catch! added a -? to the regex and updated the tests.

@clairemcginty clairemcginty marked this pull request as ready for review August 28, 2024 19:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 29, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@clairemcginty
Copy link
Copy Markdown
Contributor Author

clairemcginty commented Sep 5, 2024

cc @Abacn, since I saw you made some recent commits to Beam's avro module? :)

Abacn
Abacn reviewed Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, would you mind add this change to https://github.com/apache/beam/blob/master/CHANGES.md ?

Under New Features / Improvements Section,

Support for Zstd codec SerializableAvroCodecFactory
 is added (Java/Python) ([#32349](https://github.com/apache/beam/issues/32349)).

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Sep 8, 2024

merge conflicts after other change pushed CHANGES.md change, would you mind rebase onto the latest master? thanks!

@clairemcginty
Copy link
Copy Markdown
Contributor Author

clairemcginty commented Sep 9, 2024

merge conflicts after other change pushed CHANGES.md change, would you mind rebase onto the latest master? thanks!

cc @Abacn done! 🫡

@Abacn Abacn merged commit 1d0e09a into apache:master Sep 9, 2024
@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Sep 9, 2024

thank you for prompt responses!

@clairemcginty clairemcginty deleted the avro-io-zstd-codec branch September 9, 2024 17:35
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
@clairemcginty @reeba212
Support Zstd codec in SerializableAvroCodecFactory (apache#32352)
e3b604f 
* Support Zstd codec in SerializableAvroCodecFactory

* Test AvroIO.write

* Make tests compilable on Avro 1.8

* format

* Update CHANGES.md

* Support negative levels for zstd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abacn Abacn Abacn approved these changes

Assignees

No one assigned

Labels

extensions java Next Action: Reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support Zstd codec in SerializableAvroCodecFactory

2 participants

@clairemcginty @Abacn