Implement Java TestPrismRunner and PrismRunner#32294
Conversation
|
R: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
lostluck
left a comment
There was a problem hiding this comment.
LGTM after minor 1 requested change WRT the idle_shutdown_flag in PrismRunner.
(the others are commentary).
There was a problem hiding this comment.
I know this is supposed to be in test code, but it feels weird to have/use a hamcrest assert in production instead of the AssertionError that other things expect?
We can resolve that later as we become more comfortable with the Java test stack.
There was a problem hiding this comment.
Note, this is what TestDataflowRunner and the TestPortableRunner do, so it's fine for now.
runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismRunner.java
Outdated
Show resolved
Hide resolved
runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismRunner.java
Outdated
Show resolved
Hide resolved
runners/prism/java/src/main/java/org/apache/beam/runners/prism/TestPrismRunner.java
Outdated
Show resolved
Hide resolved
07aee17 to
40813b3
Compare
lostluck
left a comment
There was a problem hiding this comment.
Spectacular! Thanks!
I'll merge once checks pass.
This PR closes #31967, closes #31935, and closes #31935 with a Java Prism Runner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.