Skip to content

Move RunInference GC to finalize_bundle#32281

Merged
damccorm merged 1 commit intomasterfrom
users/damccorm/inference_gc
Aug 22, 2024
Merged

Move RunInference GC to finalize_bundle#32281
damccorm merged 1 commit intomasterfrom
users/damccorm/inference_gc

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

@damccorm damccorm commented Aug 22, 2024

This makes way more sense since it will save a bunch of cross process calls on large bundles

Closes #32137


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Copy Markdown
Contributor Author

R: @jrmccluskey

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Copy Markdown
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 8488a0d into master Aug 22, 2024
@damccorm damccorm deleted the users/damccorm/inference_gc branch August 22, 2024 17:36
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add timeout to RunInference operations

2 participants