Conversation
|
R: @jrmccluskey |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
jrmccluskey
left a comment
There was a problem hiding this comment.
Just a few things to clean up and clarify as far as documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32237 +/- ##
============================================
+ Coverage 77.96% 78.10% +0.14%
Complexity 3023 3023
============================================
Files 750 751 +1
Lines 96303 96465 +162
Branches 3301 3301
============================================
+ Hits 75084 75348 +264
+ Misses 19702 19600 -102
Partials 1517 1517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The added test "test_run_inference_timeout_does_garbage_collection" is flaky: https://github.com/apache/beam/actions/runs/10589109422/job/29342691220 https://github.com/apache/beam/actions/runs/10543429506/job/29211348150 |
|
Thanks - that test relies on timing, and it seems like its only broken on windows (and very rarely). So I'm not too worried its a real problem, I'll see if I can modify the test though |
* [WIP] Add timeout to runinference * More implementation including plumbing through params * Add tests + fix problems exposed by tests * Add garbage collection * typing + feature scoping * Python version * Update CHANGES * Feedback * lint
Add/expose a timeout in RunInference. This follows the path laid out in https://docs.google.com/document/d/19ves6iv-m_6DFmePJZqYpLm-bCooPu6wQ-Ti6kAl2Jo/edit to add a timeout option to RunInference so that it can be timed out and still perform garbage collection
Part of #32137
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.