Bump up google-cloud-storage version to fix data corruption issue#32135
Bump up google-cloud-storage version to fix data corruption issue#32135damccorm merged 2 commits intoapache:masterfrom
Conversation
damccorm
left a comment
There was a problem hiding this comment.
Thanks! I'll merge once checks pass
| 'google-cloud-pubsub>=2.1.0,<3', | ||
| 'google-cloud-pubsublite>=1.2.0,<2', | ||
| 'google-cloud-storage>=2.16.0,<3', | ||
| 'google-cloud-storage>=2.18.2,<3', |
There was a problem hiding this comment.
Note for others who come across this - this got bumped in a previous pr for our containers -
Abacn
left a comment
There was a problem hiding this comment.
Do we know the range of beam versions affected? Was the upstream bug always there since gcs migration?
Beam version between 2.53.0 and 2.58.0 are affected by this problem, and yes, the upstream bug had been there since gcsio migration. The bug was introduced two years ago at googleapis/google-resumable-media-python#294, which was then released as version google-resumable-media-2.3.0. We had our GcsIO migration at Beam release 2.53.0 (8ac8b20) and introduced the new dependency of google-cloud-storage-2.10.0, which depends on google-resumable-media-2.3.2. (https://github.com/googleapis/python-storage/blob/v2.10.0/setup.py#L34C6-L34C37). |
Let's document this in an issue, see examples: |
Thanks! Added #32169. |
The data corruption issue has been fixed since google-resumable-media-2.7.2 (googleapis/google-resumable-media-python#451), and it is now covered in google-cloud-storage-2.8.2 (googleapis/python-storage#1339).
fixes #32169
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.