retest this please

Similarly, for create_test.go the code there is validating that a ProtoV1 message is supported and can be encoded.

Thank you!! I had no idea about protoadapt package. I was trying to modify create_test.go to somehow work with proto v2 message. This helped clarified the goal of the test case.

You can remove the marshal interface lines.

_ proto.Marshaler   = &testProto{}
_ proto.Unmarshaler = &testProto{}

Since we aren't relying on the protoV1 unmarshalling handlers after this PR.

Done.

@lostluck
Although, this change doesn't impact any users, I believe I still have to add an entry in Changes.md . Do I add the entry under section 2.59.0 or 2.58.0?

It would go under 2.59.0 as 2.58 has already been cut and is going to be released next week.

I agree that the change is worth a small note, in the unlikely event that it breaks a protov1 user.

It would go under 2.59.0 as 2.58 has already been cut and is going to be released next week.

I agree that the change is worth a small note, in the unlikely event that it breaks a protov1 user.

Thanks. I pushed the change.

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @damondouglas for label java.
R: @jrmccluskey for label go.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 57.19%. Comparing base (bf42a81) to head (63aa49d).

@@             Coverage Diff              @@
##             master   #32045      +/-   ##
============================================
+ Coverage     57.18%   57.19%   +0.01%     
  Complexity     1474     1474              
============================================
  Files           963      963              
  Lines        152697   152818     +121     
  Branches       1076     1076              
============================================
+ Hits          87313    87409      +96     
- Misses        63202    63220      +18     
- Partials       2182     2189       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thank you!!