Skip to content

Added support for the TOKENLIST type in Spanner#32038

Merged
Abacn merged 1 commit intoapache:masterfrom
atask-g:search-index
Aug 6, 2024
Merged

Added support for the TOKENLIST type in Spanner#32038
Abacn merged 1 commit intoapache:masterfrom
atask-g:search-index

Conversation

@atask-g
Copy link
Copy Markdown
Contributor

@atask-g atask-g commented Jul 31, 2024

Extended the SpannerSchema.Column class to be able to parse a Spanner TOKENLIST typed column. This is needed to support search indexes in Teleport.
R: @darshan-sj

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @chamikaramj for label io.
R: @nielm for label spanner.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@atask-g
Copy link
Copy Markdown
Contributor Author

atask-g commented Aug 2, 2024

R: @darshan-sj

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 2, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@chamikaramj
Copy link
Copy Markdown
Contributor

Can we add a test ?

Copy link
Copy Markdown
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants