Remove --impersonate_service_account whenever PipelineOptions are serialized #32031
Merged
tvalentyn merged 2 commits intoapache:masterfrom Jul 31, 2024
Merged
Remove --impersonate_service_account whenever PipelineOptions are serialized #32031tvalentyn merged 2 commits intoapache:masterfrom
--impersonate_service_account whenever PipelineOptions are serialized #32031tvalentyn merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
R; @stephenmw |
|
LGTM Thanks! |
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
…erialized (apache#32031) * Remove the impersonate_service_account pipeline option during serialization. * Update Changes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #32030 - see the issue description for context.
Some IOs capture pipeline options and inadvertently pass them to Dataflow runner:
https://github.com/apache/beam/blob/release-2.56.0/sdks/python/apache_beam/io/gcp/bigquery.py#L723
https://github.com/apache/beam/blob/release-2.56.0/sdks/python/apache_beam/io/gcp/bigquery.py#L1148
Given that more IOs might do this in the future, this PR adds a custom serialization logic to filter out the
impersonate_service_accountoption whenever we serialize pipeline options, similarly to how we filter it out whenever we convert pipeline options into a proto:beam/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
Line 281 in e7847c9
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.