[#31991][prism] Allow Empty Composites#32024
Merged
damondouglas merged 1 commit intoapache:masterfrom Jul 30, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32024 +/- ##
============================================
- Coverage 56.92% 56.91% -0.01%
Complexity 1474 1474
============================================
Files 961 961
Lines 151462 151469 +7
Branches 1076 1076
============================================
- Hits 86215 86213 -2
- Misses 63065 63071 +6
- Partials 2182 2185 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
We don't allow expressing this in the Go SDK so no coverage is possible here. Covered by the Java tests. |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damondouglas
approved these changes
Jul 30, 2024
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows composites that only do SDK Side PCollection graph manipulation.
These composites have no payload, or subtransforms, so there's nothing for a runner to do with
them for execution. Simply ignore them.
This allows 3 Java validates runner tests in PipelineTest to pass: testIdentityTransform, testTupleProjectionTransform, and testTupleInjectionTransform.
Fixes #31991
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.