Skip to content

[Python] Managed Transforms API#31495

Merged
ahmedabu98 merged 31 commits intoapache:masterfrom
ahmedabu98:python_managed_transforms
Oct 15, 2024
Merged

[Python] Managed Transforms API#31495
ahmedabu98 merged 31 commits intoapache:masterfrom
ahmedabu98:python_managed_transforms

Conversation

@ahmedabu98
Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 commented Jun 4, 2024 •
edited
Loading

Adding Python API for Managed transforms, similar to the Java API.

@ahmedabu98 ahmedabu98 marked this pull request as draft June 4, 2024 15:17
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (bb4ad99) to head (a3067dc).
Report is 100 commits behind head on master.

❗ Current head a3067dc differs from pull request most recent head 0296f60

Please upload reports for the commit 0296f60 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #31495   +/-   ##
=========================================
  Coverage     71.14%   71.14%           
  Complexity     3008     3008           
=========================================
  Files          1055     1055           
  Lines        133439   133439           
  Branches       3248     3248           
=========================================
  Hits          94929    94929           
  Misses        35382    35382           
  Partials       3128     3128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmedabu98 ahmedabu98 marked this pull request as ready for review June 18, 2024 18:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 18, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

liferoad
liferoad reviewed Jun 27, 2024
View reviewed changes
@liferoad liferoad mentioned this pull request Jul 15, 2024
Closed
16 tasks
@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Jul 15, 2024 •
edited
Loading

Successful Dataflow run (2024-07-15_13_54_11-2004515317250011573) with the following code:

import logging
import apache_beam as beam
from apache_beam.options.pipeline_options import PipelineOptions

_LOGGER = logging.getLogger(__name__)
_LOGGER.setLevel(logging.INFO)

options = PipelineOptions([
    "--runner=DataflowRunner",
    "--job_name=managed-iceberg-read-demo",
    "--project=apache-beam-testing",
    "--temp_location=gs://apache-beam-testing-ahmedabualsaud/tmp",
    "--region=us-central1",
    "--sdk_location=sdks/python/dist/apache_beam-2.59.0.dev0.tar.gz",
    "--sdk_harness_container_image_overrides=.*java.*,gcr.io/apache-beam-testing/beam-sdk/beam_java8_sdk:latest"
])

with beam.Pipeline(options=options) as p:
    p | beam.managed.Read(
        "iceberg",
        config={
            "table": "my_database.my_table",
            "catalog_name": "ahmed_catalog",
            "catalog_properties": {
                "catalog-impl": "org.apache.iceberg.hadoop.HadoopCatalog",
                "warehouse": "gs://ahmedabualsaud-apache-beam-testing"
            }}) | "Log rows" >> beam.Map(_LOGGER.info)

Note: I had to include the following dependencies (needed by Iceberg) in the expansion service jar:

runtimeOnly library.java.hadoop_client
runtimeOnly library.java.bigdataoss_gcsio
runtimeOnly library.java.bigdataoss_gcs_connector
runtimeOnly library.java.bigdataoss_util_hadoop

tvalentyn
tvalentyn reviewed Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tvalentyn tvalentyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments but Cham would have more context.

tvalentyn
tvalentyn reviewed Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments but Cham would be have more context.

chamikaramj
chamikaramj reviewed Jul 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liferoad liferoad added this to the 2.60.0 Release milestone Aug 26, 2024
@ahmedabu98 ahmedabu98 removed this from the 2.60.0 Release milestone Oct 4, 2024
@github-actions github-actions bot added the build label Oct 10, 2024
@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Oct 11, 2024

@chamikaramj the last comment was just addressed. It's been a while though, lmk if you'd like to take another quick look before I merge

chamikaramj
chamikaramj reviewed Oct 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

sdks/python/apache_beam/transforms/managed_it_test.py
import shutil
import tempfile
import time
import unittest
Copy link
Copy Markdown
Contributor

@chamikaramj chamikaramj Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this file should be named "managed_iceberg_it_test.py"

@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Oct 15, 2024

Fixes #31830

@ahmedabu98 ahmedabu98 merged commit 9a2d456 into apache:master Oct 15, 2024
@tvalentyn
Copy link
Copy Markdown
Contributor

tvalentyn commented Oct 15, 2024

Looks like we merged this with
beam_PreCommit_RAT (Run RAT PreCommit) failing, and it is still broken at master @ahmedabu98 - could you PTAL? Thanks!

@tvalentyn
Copy link
Copy Markdown
Contributor

tvalentyn commented Oct 15, 2024 

> Task :rat
Files with unapproved licenses:
 - /runner/_work/beam/beam/sdks/python/apache_beam/transforms/managed_iceberg_it_test.py

@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Oct 15, 2024

Ahh my apologies, I didn't pay attention and thought the failure was a flake

@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Oct 15, 2024

Opened #32785

reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
@ahmedabu98 @reeba212
[Python] Managed Transforms API (apache#31495)
4f2ed62 
* managed module

* clean up

* lint

* try with real example

* cleanup

* add documentation

* fix doc

* add pyyaml dependency

* cleanup

* return deps

* return deps

* fix doc

* address some comments

* doc updates

* define managed transform URNs in proto

* fix URN

* remove managed dependency

* add managed iceberg integration test

* lint

* lint

* dependency fix

* lint

* dependency fix

* dependency fix

* lint

* lint

* dependency fix

* rename test file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvalentyn tvalentyn tvalentyn left review comments

@chamikaramj chamikaramj chamikaramj left review comments

@liferoad liferoad liferoad approved these changes

Assignees

No one assigned

Labels

build io java kafka model python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahmedabu98 @chamikaramj @tvalentyn @liferoad