Include everit_json_schema in schemaio expansion service uber jar by kennknowles · Pull Request #30779 · apache/beam

kennknowles · 2024-03-28T00:34:48Z

I think this fixes #30776

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

kennknowles · 2024-03-28T00:35:06Z

@Polber can you check if this does what you need?

kennknowles · 2024-03-28T00:45:11Z

Confirmed:

$ jar -tf sdks/java/extensions/schemaio-expansion-service/build/libs/beam-sdks-java-extensions-schemaio-expansion-service-2.56.0-SNAPSHOT.jar

yields

org/everit/json/
org/everit/json/schema/
org/everit/json/schema/ArraySchema$Builder.class
org/everit/json/schema/ArraySchema.class
org/everit/json/schema/ArraySchemaValidatingVisitor.class
org/everit/json/schema/BooleanSchema$Builder.class
org/everit/json/schema/BooleanSchema.class
org/everit/json/schema/CollectingFailureReporter.class
org/everit/json/schema/CombinedSchema$1.class
org/everit/json/schema/CombinedSchema$2.class
org/everit/json/schema/CombinedSchema$3.class
org/everit/json/schema/CombinedSchema$Builder.class
org/everit/json/schema/CombinedSchema$ValidationCriterion.class
org/everit/json/schema/CombinedSchema.class
org/everit/json/schema/ConditionalSchema$Builder.class
org/everit/json/schema/ConditionalSchema.class
org/everit/json/schema/ConditionalSchemaValidatingVisitor.class
org/everit/json/schema/ConstSchema$ConstSchemaBuilder.class
org/everit/json/schema/ConstSchema.class
org/everit/json/schema/DefaultValidator.class
org/everit/json/schema/EarlyFailingFailureReporter.class
org/everit/json/schema/EmptySchema$Builder.class
org/everit/json/schema/EmptySchema.class
org/everit/json/schema/EnumSchema$Builder.class
org/everit/json/schema/EnumSchema.class
org/everit/json/schema/FalseSchema$Builder.class
org/everit/json/schema/FalseSchema.class
org/everit/json/schema/FormatValidator.class
org/everit/json/schema/InternalValidationException.class
org/everit/json/schema/JSONPointer$Builder.class
org/everit/json/schema/JSONPointer.class
org/everit/json/schema/JSONPointerException.class
org/everit/json/schema/NotSchema$Builder.class
org/everit/json/schema/NotSchema.class
org/everit/json/schema/NullSchema$Builder.class
org/everit/json/schema/NullSchema.class
org/everit/json/schema/NumberComparator.class
org/everit/json/schema/NumberSchema$Builder.class
org/everit/json/schema/NumberSchema.class
org/everit/json/schema/NumberSchemaValidatingVisitor.class
org/everit/json/schema/ObjectComparator.class
org/everit/json/schema/ObjectSchema$Builder.class
org/everit/json/schema/ObjectSchema.class
org/everit/json/schema/ObjectSchemaValidatingVisitor.class
org/everit/json/schema/PrimitiveValidationStrategy.class
org/everit/json/schema/ReadOnlyValidator.class
org/everit/json/schema/ReadWriteContext.class
org/everit/json/schema/ReadWriteValidator.class
org/everit/json/schema/ReferenceSchema$Builder.class
org/everit/json/schema/ReferenceSchema.class
org/everit/json/schema/Schema$Builder.class
org/everit/json/schema/Schema.class
org/everit/json/schema/SchemaException.class
org/everit/json/schema/SchemaLocation.class
org/everit/json/schema/StringSchema$Builder.class
org/everit/json/schema/StringSchema.class
org/everit/json/schema/StringSchemaValidatingVisitor.class
org/everit/json/schema/StringToValueConverter.class
org/everit/json/schema/ToStringVisitor.class
org/everit/json/schema/TrueSchema$Builder.class
org/everit/json/schema/TrueSchema.class
org/everit/json/schema/TypeChecker.class
org/everit/json/schema/ValidatingVisitor.class
org/everit/json/schema/ValidationException.class
org/everit/json/schema/ValidationFailureReporter.class
org/everit/json/schema/Validator$ValidatorBuilder.class
org/everit/json/schema/Validator.class
org/everit/json/schema/Visitor.class
org/everit/json/schema/WriteOnlyValidator.class
org/everit/json/schema/event/
org/everit/json/schema/event/CombinedSchemaMatchEvent.class
org/everit/json/schema/event/CombinedSchemaMismatchEvent.class
org/everit/json/schema/event/CombinedSchemaValidationEvent.class
org/everit/json/schema/event/ConditionalSchemaMatchEvent.class
org/everit/json/schema/event/ConditionalSchemaMismatchEvent.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$1.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword$1.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword$2.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword$3.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent.class
org/everit/json/schema/event/MismatchEvent.class
org/everit/json/schema/event/SchemaReferencedEvent.class
org/everit/json/schema/event/ValidationEvent.class
org/everit/json/schema/event/ValidationListener$1.class
org/everit/json/schema/event/ValidationListener.class
org/everit/json/schema/internal/
org/everit/json/schema/internal/DateFormatValidator.class
org/everit/json/schema/internal/DateTimeFormatValidator$Delegate.class
org/everit/json/schema/internal/DateTimeFormatValidator.class
org/everit/json/schema/internal/EmailFormatValidator.class
org/everit/json/schema/internal/HostnameFormatValidator.class
org/everit/json/schema/internal/IPAddressValidator.class
org/everit/json/schema/internal/IPV4Validator.class
org/everit/json/schema/internal/IPV6Validator.class
org/everit/json/schema/internal/JSONPrinter.class
org/everit/json/schema/internal/JSONWriter.class
org/everit/json/schema/internal/JsonPointerFormatValidator.class
org/everit/json/schema/internal/RegexFormatValidator.class
org/everit/json/schema/internal/RelativeJsonPointerFormatValidator$ParseException.class
org/everit/json/schema/internal/RelativeJsonPointerFormatValidator$Parser.class
org/everit/json/schema/internal/RelativeJsonPointerFormatValidator.class
org/everit/json/schema/internal/TemporalFormatValidator.class
org/everit/json/schema/internal/TimeFormatValidator.class
org/everit/json/schema/internal/URIFormatValidator.class
org/everit/json/schema/internal/URIReferenceFormatValidator.class
org/everit/json/schema/internal/URITemplateFormatValidator.class
org/everit/json/schema/internal/URIV4FormatValidator.class
org/everit/json/schema/loader/
org/everit/json/schema/loader/AbstractSchemaExtractor.class
org/everit/json/schema/loader/AdjacentSchemaExtractionState.class
org/everit/json/schema/loader/ArraySchemaLoader.class
org/everit/json/schema/loader/ClassPathAwareSchemaClient.class
org/everit/json/schema/loader/CombinedSchemaLoader$CombinedSchemaProvider.class
org/everit/json/schema/loader/CombinedSchemaLoader.class
org/everit/json/schema/loader/ConstSchemaExtractor.class
org/everit/json/schema/loader/EnumSchemaExtractor.class
org/everit/json/schema/loader/ExclusiveLimitHandler$1.class
org/everit/json/schema/loader/ExclusiveLimitHandler.class
org/everit/json/schema/loader/ExtractionResult.class
org/everit/json/schema/loader/JsonArray.class
org/everit/json/schema/loader/JsonArrayIterator.class
org/everit/json/schema/loader/JsonObject.class
org/everit/json/schema/loader/JsonObjectIterator.class
org/everit/json/schema/loader/JsonPointerEvaluator$QueryResult.class
org/everit/json/schema/loader/JsonPointerEvaluator.class
org/everit/json/schema/loader/JsonValue$Multiplexer.class
org/everit/json/schema/loader/JsonValue$VoidMultiplexer.class
org/everit/json/schema/loader/JsonValue$VoidMultiplexerWithSchemaPredicate.class
org/everit/json/schema/loader/JsonValue.class
org/everit/json/schema/loader/KeyConsumer.class
org/everit/json/schema/loader/LoaderConfig.class
org/everit/json/schema/loader/LoadingState.class
org/everit/json/schema/loader/NotSchemaExtractor.class
org/everit/json/schema/loader/ObjectSchemaLoader.class
org/everit/json/schema/loader/OrgJsonUtil.class
org/everit/json/schema/loader/ProjectedJsonObject.class
org/everit/json/schema/loader/PropertySnifferSchemaExtractor.class
org/everit/json/schema/loader/ReferenceKnot.class
org/everit/json/schema/loader/ReferenceLookup.class
org/everit/json/schema/loader/ReferenceSchemaExtractor.class
org/everit/json/schema/loader/SchemaClient.class
org/everit/json/schema/loader/SchemaExtractor.class
org/everit/json/schema/loader/SchemaLoader$SchemaLoaderBuilder.class
org/everit/json/schema/loader/SchemaLoader.class
org/everit/json/schema/loader/SpecificationVersion$1.class
org/everit/json/schema/loader/SpecificationVersion$2.class
org/everit/json/schema/loader/SpecificationVersion$3.class
org/everit/json/schema/loader/SpecificationVersion.class
org/everit/json/schema/loader/StringSchemaLoader.class
org/everit/json/schema/loader/SubschemaRegistry.class
org/everit/json/schema/loader/TypeBasedSchemaExtractor.class
org/everit/json/schema/loader/Uri.class
org/everit/json/schema/loader/V4ExclusiveLimitHandler.class
org/everit/json/schema/loader/V6ExclusiveLimitHandler.class
org/everit/json/schema/loader/internal/
org/everit/json/schema/loader/internal/DefaultSchemaClient.class
org/everit/json/schema/loader/internal/JSONPointer$QueryResult.class
org/everit/json/schema/loader/internal/JSONPointer.class
org/everit/json/schema/loader/internal/ReferenceResolver.class
org/everit/json/schema/loader/internal/ResolutionScopeChangeListener.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer$IdModifyingTypeConsumerImpl.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer$OnTypeConsumer.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer$OnTypeConsumerImpl.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer.class
org/everit/json/schema/loader/internal/WrappingFormatValidator.class
org/everit/json/schema/regexp/
org/everit/json/schema/regexp/AbstractRegexp.class
org/everit/json/schema/regexp/JavaUtilRegexp.class
org/everit/json/schema/regexp/JavaUtilRegexpFactory.class
org/everit/json/schema/regexp/RE2JRegexp.class
org/everit/json/schema/regexp/RE2JRegexpFactory.class
org/everit/json/schema/regexp/Regexp.class
org/everit/json/schema/regexp/RegexpFactory.class
org/everit/json/schema/regexp/RegexpMatchingFailure.class

github-actions · 2024-03-28T01:26:24Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damondouglas

LGTM

…0779)

…0779) (#30823) Co-authored-by: Kenn Knowles <kenn@apache.org>

…ache#30779)

kennknowles marked this pull request as ready for review March 28, 2024 00:34

github-actions bot added java extensions labels Mar 28, 2024

Include everit_json_schema in schemaio expansion service uber jar

88c7c33

kennknowles force-pushed the json branch from 47a4108 to 88c7c33 Compare March 28, 2024 00:42

github-actions bot added the Next Action: Reviewers label Mar 28, 2024

damondouglas approved these changes Mar 28, 2024

View reviewed changes

Polber approved these changes Mar 29, 2024

View reviewed changes

Abacn merged commit 336e870 into apache:master Apr 1, 2024

damccorm pushed a commit that referenced this pull request Apr 1, 2024

Include everit_json_schema in schemaio expansion service uber jar (#3…

fe9bbb1

…0779)

damccorm added a commit that referenced this pull request Apr 2, 2024

Include everit_json_schema in schemaio expansion service uber jar (#3…

e9422c2

…0779) (#30823) Co-authored-by: Kenn Knowles <kenn@apache.org>

hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024

Include everit_json_schema in schemaio expansion service uber jar (ap…

4c04795

…ache#30779)

robertwb mentioned this pull request Apr 5, 2024

[YAML] Disable Java variant of WriteToJson #30777

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include everit_json_schema in schemaio expansion service uber jar#30779

Include everit_json_schema in schemaio expansion service uber jar#30779
Abacn merged 1 commit intoapache:masterfrom
kennknowles:json

kennknowles commented Mar 28, 2024

Uh oh!

kennknowles commented Mar 28, 2024

Uh oh!

kennknowles commented Mar 28, 2024

Uh oh!

github-actions bot commented Mar 28, 2024

Uh oh!

damondouglas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kennknowles commented Mar 28, 2024

GitHub Actions Tests Status (on master branch)

Uh oh!

kennknowles commented Mar 28, 2024

Uh oh!

kennknowles commented Mar 28, 2024

Uh oh!

github-actions bot commented Mar 28, 2024

Uh oh!

damondouglas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants