Skip to content

Fix JdbcIO PreCommit mysql breaking change#30179

Merged
Abacn merged 1 commit intoapache:masterfrom
Abacn:fixjdbc
Feb 1, 2024
Merged

Fix JdbcIO PreCommit mysql breaking change#30179
Abacn merged 1 commit intoapache:masterfrom
Abacn:fixjdbc

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Feb 1, 2024

Fixes https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_JDBC_IO_Direct.yml?query=event%3Aschedule

context: #30024 (comment)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn Abacn marked this pull request as ready for review February 1, 2024 02:54
@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Feb 1, 2024

R: @Polber

CC: @lostluck this one is also currently failing on release branch. But it is just a test issue so not a release blocker

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Feb 1, 2024

R: @damccorm

Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Abacn Abacn merged commit 96cf695 into apache:master Feb 1, 2024
@Abacn Abacn deleted the fixjdbc branch February 1, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants