Skip to content

[YAML] Add ability to specify JDBC type to read/write#30024

Merged
robertwb merged 4 commits intoapache:masterfrom
Polber:jkinard/jdbc-combine
Feb 8, 2024
Merged

[YAML] Add ability to specify JDBC type to read/write#30024
robertwb merged 4 commits intoapache:masterfrom
Polber:jkinard/jdbc-combine

Conversation

@Polber
Copy link
Copy Markdown
Contributor

@Polber Polber commented Jan 16, 2024

PR adds ability to specify a JDBC type/flavor to the ReadFromJdbc and WriteToJdbc Beam YAML transforms.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Polber added 3 commits January 12, 2024 14:41
@Polber
[yaml] Revise yaml user label
79a9b37 
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber
adjust yaml tag key
671b239 
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber
[YAML] Add ability to specify JDBC type to read/write
c39f795 
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 16, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @damondouglas for label java.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damondouglas
damondouglas requested changes Jan 17, 2024
View reviewed changes
Comment thread .../java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java Outdated
Comment thread .../java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 26, 2024

Reminder, please take a look at this pr: @liferoad @damondouglas @damondouglas

robertwb
robertwb reviewed Jan 27, 2024
View reviewed changes
Comment thread .../java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java Outdated
Comment thread ...java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java
@Polber Polber force-pushed the jkinard/jdbc-combine branch 2 times, most recently from d899182 to d3530cb Compare January 31, 2024 20:12
robertwb
robertwb reviewed Jan 31, 2024
View reviewed changes
Comment thread sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcUtil.java Outdated
@Polber
Copy link
Copy Markdown
Contributor Author

Polber commented Jan 31, 2024

@Abacn Is the test failing a known issue? It is failing at container startup for mysql, but I'm not sure why my PR would affect that.

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Jan 31, 2024 •
edited
Loading

@Abacn Is the test failing a known issue? It is failing at container startup for mysql, but I'm not sure why my PR would affect that.

It's new issue. It's failing since Jan 19th: https://github.com/apache/beam/actions/runs/7580901305. The likely cause is new version of mysql:latest breaking the test:

INFO: Creating container for image: mysql:latest
Jan 19, 2024 7:48:19 AM org.testcontainers.containers.GenericContainer tryStart
INFO: Container mysql:latest is starting: 424952070b3851f1212a5c750f3d8c06ec591c9b6b4d605c4b2d2458520fa570
Jan 19, 2024 7:48:20 AM org.testcontainers.containers.JdbcDatabaseContainer waitUntilContainerStarted
INFO: Waiting for database connection to become available at jdbc:mysql://localhost:32770/test using query 'SELECT 1'
Jan 19, 2024 7:50:20 AM org.testcontainers.containers.GenericContainer tryStart
SEVERE: Could not start container
...
2024-01-19 07:48:20+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.3.0-1.el8 started.
2024-01-19T07:48:20.688228Z 0 [System] [MY-015017] [Server] MySQL Server Initialization - start.
2024-01-19T07:48:20.690591Z 0 [System] [MY-013169] [Server] /usr/sbin/mysqld (mysqld 8.3.0) initializing of server in progress as process 80
2024-01-19T07:48:20.718410Z 0 [Warning] [MY-013907] [InnoDB] Deprecated configuration parameters innodb_log_file_size and/or innodb_log_files_in_group have been used to compute innodb_redo_log_capacity=10485760. Please use innodb_redo_log_capacity instead.
2024-01-19T07:48:20.720217Z 1 [System] [MY-013576] [InnoDB] InnoDB initialization has started.
2024-01-19T07:48:21.543326Z 1 [System] [MY-013577] [InnoDB] InnoDB initialization has ended.
2024-01-19T07:48:23.615862Z 0 [ERROR] [MY-000068] [Server] unknown option '--skip-host-cache'.
2024-01-19T07:48:23.616241Z 0 [ERROR] [MY-013236] [Server] The designated data directory /var/lib/mysql/ is unusable. You can remove all files that the server added to it.
2024-01-19T07:48:23.616261Z 0 [ERROR] [MY-010119] [Server] Aborting
2024-01-19T07:48:24.963938Z 0 [System] [MY-015018] [Server] MySQL Server Initialization - end.

Update: this is affected by testcontainers/testcontainers-java#8130

@Abacn Abacn mentioned this pull request Feb 1, 2024
Merged
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

Reminder, please take a look at this pr: @liferoad @damondouglas @damondouglas

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Feb 8, 2024

What is the status of this now, @damondouglas were the change request resolved?

btw good to test Python PostCommit. Python Jdbc integration test often found break after related changes and not captured by precommit

@Polber
add jdbc type map and unit tests
1276101 
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber Polber force-pushed the jkinard/jdbc-combine branch from d3530cb to 1276101 Compare February 8, 2024 16:47
@github-actions github-actions Bot added build and removed build labels Feb 8, 2024
damondouglas
damondouglas approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Polber

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Feb 8, 2024

Test passed:

PASSED                                                                   [ 70%]
  apache_beam/io/external/xlang_jdbcio_it_test.py::CrossLanguageJdbcIOTest::test_xlang_jdbc_write_read_1_mysql

@robertwb robertwb merged commit 619c0d9 into apache:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertwb robertwb robertwb approved these changes

@damondouglas damondouglas damondouglas approved these changes

Assignees

No one assigned

Labels

io java jdbc Next Action: Reviewers python yaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Polber @Abacn @robertwb @damondouglas