Revert the value of MAX_BATCH_OPERATION_SIZE in gcsio#29503
Merged
johnjcasey merged 1 commit intoapache:masterfrom Nov 21, 2023
Merged
Revert the value of MAX_BATCH_OPERATION_SIZE in gcsio#29503johnjcasey merged 1 commit intoapache:masterfrom
johnjcasey merged 1 commit intoapache:masterfrom
Conversation
This value was changed in PR apache#29360 to 1000, which led to internal test failure.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29503 +/- ##
=======================================
Coverage 37.85% 37.85%
=======================================
Files 690 690
Lines 101306 101306
=======================================
Hits 38350 38350
Misses 61363 61363
Partials 1593 1593
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
|
LGTM |
riteshghorse
pushed a commit
to riteshghorse/beam
that referenced
this pull request
Nov 21, 2023
This value was changed in PR apache#29360 to 1000, which led to internal test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This value was changed in PR #29360 to 1000, which led to internal test failure.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.