Conversation
There was a problem hiding this comment.
I think this is redundant since there are no other jobs to run
There was a problem hiding this comment.
Resolved. thanks
There was a problem hiding this comment.
Since there is no explicitly specified job timeout, it should be 100 by default
There was a problem hiding this comment.
It should be triggered once per day. Should be something like this: 0 0 * * *
There was a problem hiding this comment.
It should be triggered once per day. Should be something like this: 0 0 * * *
There was a problem hiding this comment.
See the comment above
There was a problem hiding this comment.
See the comment above
There was a problem hiding this comment.
Done.
Thanks for taking a look
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
@damccorm @Abacn This one is ok but the workflows are failing at post setup: https://github.com/apache/beam/actions/runs/6250265622/job/16969850271?pr=28528 Any idea what might be causing this? |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@volatilemolotov could you try pulling in the latest changes from master? |
damccorm
left a comment
There was a problem hiding this comment.
LGTM once we get the workflows green (I think pulling in master should do it)
248c425 to
dfbdbcc
Compare
|
All green once master changes have been pulled in |
|
Thanks! |
adds
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.