Fix remaining tests for pandas 2 compatibility#28524
Merged
tvalentyn merged 4 commits intoapache:masterfrom Sep 21, 2023
Merged
Fix remaining tests for pandas 2 compatibility#28524tvalentyn merged 4 commits intoapache:masterfrom
tvalentyn merged 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
R: @tvalentyn |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28524 +/- ##
==========================================
+ Coverage 72.23% 72.25% +0.01%
==========================================
Files 684 684
Lines 100992 100931 -61
==========================================
- Hits 72951 72926 -25
+ Misses 26466 26430 -36
Partials 1575 1575
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Contributor
|
Run Python_Coverage PreCommit |
Contributor
Author
|
PTAL. Skipped the xs test as discussed, and pytest passes everything for me lets see if it fails again here. |
tvalentyn
approved these changes
Sep 20, 2023
Contributor
|
which of the 1-4 chages affected pandas 1.4 ? |
Contributor
Author
|
None, I had just removed a doc test thinking it was covered by something
else but it wasn't.
…On Wed, Sep 20, 2023, 6:17 PM tvalentyn ***@***.***> wrote:
which of the 1-4 chages affected pandas 1.4 ?
—
Reply to this email directly, view it on GitHub
<#28524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG4SH4Z4TH4JKCO7KQRPMTX3NTNZANCNFSM6AAAAAA46BSVAU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the remaining tests without open questions.
Umbrella Issue: #27221