Add Load Tests GBK Dataflow Batch Go workflow#28449
Conversation
There was a problem hiding this comment.
I'm not sure about the correct answer, but could we implement a matrix of file names here and execute them all in parallel? Is this suitable for load testing?
For example, a matrix could be: file_names: [config_GBK_Go_Batch_10b.txt, config_GBK_Go_Batch_100b.txt, ..., etc]. The other steps seem similar.
Thank you.
There was a problem hiding this comment.
I think no, because:
- there is no need to run 2MB test if 10KB test is failing
- sometimes in load tests we have steps that should be done before one bunch of tests (e.g. start flink) and some steps before another bunch (e.g. restart flink), and some steps that should be done only after all tests (e.g. teardown flink)
There was a problem hiding this comment.
I agree with not doing it via matrix, but could we simplify this with a list/loop? If its ugly in bash, we could also consider https://github.com/actions/github-script
a8593e1 to
c6ba677
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
I think I mentioned this on another pr, but could we add an explanatory comment describing why we're doing this step? It is hard to determine intent from reading the code.
There was a problem hiding this comment.
I agree with not doing it via matrix, but could we simplify this with a list/loop? If its ugly in bash, we could also consider https://github.com/actions/github-script
c6ba677 to
daf19b3
Compare
|
Looks like there are conflicts, please resolve and I'll merge |
daf19b3 to
7c06607
Compare
Resolved |
* Add Load Tests GBK Dataflow Batch Go workflow * Refactoring
The following jenkins job has been migrated:
https://ci-beam.apache.org/job/beam_LoadTests_Go_GBK_Dataflow_Batch
https://ci-beam.apache.org/job/beam_LoadTests_Go_GBK_Dataflow_Batch_PR
How has it been tested?
The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.