Add Python Load Tests Combine Dataflow Batch github action#28431
Add Python Load Tests Combine Dataflow Batch github action#28431damccorm merged 3 commits intoapache:masterfrom
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
What is this 2nd echo doing (here and in other configs)?
There was a problem hiding this comment.
It replaces job_name substring with the "name+current date".
In .groovy it was:
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
...
job_name : "load-tests-python-dataflow-batch-combine-1-${now}"
There was a problem hiding this comment.
Could you add an explanatory comment to this section explaining what we are doing? It is hard to gather intent from the code
2330a42 to
adbac74
Compare
adbac74 to
ad0b256
Compare
The following jenkins job has been migrated:
https://ci-beam.apache.org/job/beam_LoadTests_Python_Combine_Dataflow_Batch
https://ci-beam.apache.org/job/beam_LoadTests_Python_Combine_Dataflow_Batch_PR
How has it been tested?
The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.