Conversation
* Fix InlineMe errorprone warning * Fix new errorprones used in new guava * Fix serialization test
|
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report
@@ Coverage Diff @@
## master #27895 +/- ##
==========================================
- Coverage 70.83% 70.58% -0.25%
==========================================
Files 861 857 -4
Lines 104732 103938 -794
==========================================
- Hits 74183 73368 -815
- Misses 28990 29011 +21
Partials 1559 1559
Flags with carried forward coverage won't be shown. Click here to find out more. see 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Run CommunityMetrics PreCommit |
|
Run GoPortable PreCommit failed twice with different reasons -- passed in third run |
|
Tests passed (except the two rerunning one, and not related to java) there are tests results not updating to github UI, 5 of them does not even has link, but all passed: https://ci-beam.apache.org/job/beam_PreCommit_Java_Amqp_IO_Direct_Commit/547/ https://ci-beam.apache.org/job/beam_PreCommit_Java_HBase_IO_Direct_Commit/560/ https://ci-beam.apache.org/job/beam_PreCommit_Java_Solr_IO_Direct_Commit/558/ https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/27951/ https://ci-beam.apache.org/job/beam_PreCommit_Website_Stage_GCS_Commit/11764/ |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run GoPortable PreCommit |
| * https://github.com/apache/beam/commit/ca0787642a6b3804a742326147281c99ae8d08d2 | ||
| */ | ||
|
|
||
| /** This was generated manually. */ |
There was a problem hiding this comment.
nit Can you comment on how this was generated manually? Or you just used the failure to set as a baseline?
There was a problem hiding this comment.
Yeah, just used the error message which prints serializedCheckpoint to set the base line:
bvolpato
left a comment
There was a problem hiding this comment.
LGTM, thanks for pushing this Yi! It will be nice to move to a newer Guava!
|
going to use merge instead of squash to preserve two commit history (one trivial replace, one fix) |
|
Thanks for push this fix through! @Abacn |
Fixes #27801
The first commit is trivial 26.0-jre->32.1.2-jre replace, and the following commit(s) fix the errorprone/checkstyle rules that are introduced in new guava versions
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.