[Python] Create BigQuery wrapper with pipeline options when performing reads#27583
Merged
riteshghorse merged 1 commit intoapache:masterfrom Jul 21, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27583 +/- ##
=======================================
Coverage 71.14% 71.14%
=======================================
Files 861 861
Lines 104560 104560
=======================================
+ Hits 74390 74393 +3
+ Misses 28622 28619 -3
Partials 1548 1548
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
riteshghorse
approved these changes
Jul 21, 2023
Contributor
riteshghorse
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User mentioned they had trouble reading from an external table connected to a Google sheet because of missing Google Drive credentials. Credentials can be passed in using the
GoogleCloudOptions.gcp_oauth_scopes, attribute but we were always creating the BQ wrapper with an empty PipelineOptions object.These changes create the wrappers using the pipeline's options instead.