Use PipelineOptions for constructing BigQueryWrapper when estimating BigQuery table size (#26622)#26662
Merged
Abacn merged 3 commits intoapache:masterfrom May 31, 2023
Merged
Conversation
BigQueryWrapper factory method with PipelineOptions (#26622)PipelineOptions in BigQueryWrapper when estimating _BigQuery_ table size (#26622)
PipelineOptions in BigQueryWrapper when estimating _BigQuery_ table size (#26622)PipelineOptions for constructing BigQueryWrapper when estimating BigQuery table size (#26622)
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
|
For the Format check fail, run this command to fix: |
Contributor
|
waiting on author |
Codecov Report
@@ Coverage Diff @@
## master #26662 +/- ##
==========================================
- Coverage 72.06% 71.93% -0.14%
==========================================
Files 745 747 +2
Lines 101200 101467 +267
==========================================
+ Hits 72930 72986 +56
- Misses 26810 27021 +211
Partials 1460 1460
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
I've reformatted the code as you suggested 🙂 |
Contributor
|
Run Python_Runners PreCommit |
Contributor
|
Thank you! |
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
…ing BigQuery table size (apache#26622) (apache#26662) * Add `BigQueryWrapper` factory method with `PipelineOptions` (apache#26622) * Pass `PipelineOptions` to `BigQueryWrapper` when estimating table size (apache#26622) * Reformat `bigquery_tools.py` (apache#26622)
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses issue #26622.
Changes made:
BigQueryWrapperthat allows for specifyingPipelineOptionsfor which the Google Cloud Platform credentials are retrieved for the underlying BigQuery client,PipelineOptionstoBigQueryWrapperwhen estimating BigQuery table size.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.