Playground integration test run and editing by Malarg · Pull Request #25033 · apache/beam

Malarg · 2023-01-17T09:18:04Z

Playground integration test run and editing

Resolves #24936
Resolves #24923
Resolves #24922
Resolves #24921
Resolves #24937
Resolves #24938
Resolves #24939
Resolves #24940
Resolves #24941
Resolves #25051
Resolves #25052
Resolves #25053
Resolves #25278

resolves #25329
resolves #25331
resolves #25336
resolves #25332
resolves #25333

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

…hange the example (apache#24730) (apache#24729)

…ache#24730)

* Integration test for changing SDK and running code (apache#24779) * Rename an integration test (apache#24779) * Use enum to switch SDK in integration test (apache#24779) * Find SDK in a dropdown by key (apache#24779) * Add a TODO (apache#24779) * Fix exports (apache#24779)

* Integration test for changing SDK and running code (apache#24779) * Rename an integration test (apache#24779) * Use enum to switch SDK in integration test (apache#24779) * Find SDK in a dropdown by key (apache#24779) * Add a TODO (apache#24779) * Fix exports (apache#24779) * Integration tests miscellaneous UI (#383) * miscellaneous ui integration tests * reverted pubspec.lock * gradle tasks ordered alhpabetically * integration tests refactoring * clean code * integration tests miscellaneous ui fix pr * rename method * added layout adaptivity * A minor cleanup (apache#24779) Co-authored-by: Dmitry Repin <mr.malarg@gmail.com>

alexeyinkin · 2023-01-18T08:05:21Z

playground/frontend/integration_test/standalone_run_shortcuts_test.dart

+  final startSource = controller.source;
+  await wt.enterText(find.codeField(), 'print("Hello World!');
+
+  expect(startSource != controller.source, true);


Suggested change

expect(startSource != controller.source, true);

expect(controller.source, isNot(startSource));

alexeyinkin · 2023-01-18T10:54:01Z

playground/frontend/integration_test/standalone_run_shortcuts_test.dart

+
+  expect(startSource != controller.source, true);
+
+  await wt.runShortcut(controller.resetShortcut.shortcuts.keys);


Make shortcuts OS-dependent.

Done. Check, please

All 5 shortcuts work in Ubuntu.

alexeyinkin · 2023-01-18T10:56:51Z

playground/frontend/integration_test/common/common_finders.dart

 import 'package:playground_components_dev/playground_components_dev.dart';

 extension CommonFindersExtension on CommonFinders {
+  Finder appDropdownButtonWithText(String text) {


Look for PipelineOptionsDropdown.

alexeyinkin · 2023-01-18T11:06:03Z

playground/frontend/integration_test/standalone_change_pipeline_options_and_run_test.dart

+      await wt.tapAndSettle(find.runOrCancelButton());
+
+      final playgroundController = wt.findPlaygroundController();
+      expect(playgroundController.outputResult, contains('Pipeline cancelled'));


Use a constant?

alexeyinkin · 2023-01-18T11:07:07Z

playground/frontend/integration_test/standalone_change_pipeline_options_and_run_test.dart

+
+      _checkIfRawTextCorrect('--some test --some2 test2');
+
+      await wt.tapAndSettle(find.pipelineOptionsOptionsTab());


Suggested change

await wt.tapAndSettle(find.pipelineOptionsOptionsTab());

await wt.tapAndSettle(find.pipelineOptionsListTab());

alexeyinkin · 2023-01-18T11:26:24Z

playground/frontend/integration_test/standalone_editing_test.dart

+  );
+}
+
+Future<void> _editingAndResettingChanges(WidgetTester wt) async {


Split to 2 methods.

alexeyinkin · 2023-01-18T11:27:09Z

playground/frontend/integration_test/standalone_editing_test.dart

+  expect(playgroundController.source, equals(code));
+}
+
+Future<void> _checkCodeHighlighting(WidgetTester wt) async {


Suggested change

Future<void> _checkCodeHighlighting(WidgetTester wt) async {

Future<void> _expectMoreThanOneColor(WidgetTester wt) async {

alexeyinkin · 2023-01-18T11:28:45Z

playground/frontend/integration_test/standalone_editing_test.dart

+  Finder foldToggles = _getFoldToggles();
+
+  Finder topToggle =
+      wt.getCenter(foldToggles.at(0)).dy < wt.getCenter(foldToggles.at(1)).dy


Look for inputs the same way, comparing their centers, remove keys from inputs.

alexeyinkin · 2023-01-18T11:30:14Z

playground/frontend/integration_test/standalone_example_selector_test.dart

+  await wt.tapAndSettle(find.exampleSelector());
+  await wt.tapAndSettle(find.exampleSelector());


Comment please.

alexeyinkin · 2023-01-18T11:32:06Z

playground/frontend/integration_test/standalone_example_selector_test.dart

+    await _checkFilteringExamplesByTags(wt);
+    await _checkFilteringExamplesBySearchString(wt);


Check the actual examples before filtering and after filtering.

alexeyinkin · 2023-01-24T10:29:48Z

playground/frontend/build.gradle

+}
+
+tasks.register("integrationTest_standalone_cancel_running_example") {
+  runIntegrationTest("standalone_cancel_running_example", "/")


doLast everywhere.

alexeyinkin · 2023-01-24T10:37:16Z

playground/frontend/integration_test/standalone_cancel_running_example_test.dart

+      duration,
+    );
+  } catch (e) {
+    //ignore


alexeyinkin · 2023-01-24T10:39:50Z

playground/frontend/integration_test/standalone_cancel_running_example_test.dart

+    final source = wt
+            .findPlaygroundController()
+            .snippetEditingController
+            ?.activeFileController
+            ?.codeController
+            .fullText ??
+        '';


Check if there is a getter for this. It may be on the Copy button of the embedded playground.

alexeyinkin · 2023-01-24T10:41:25Z

playground/frontend/integration_test/standalone_change_pipeline_options_and_run_test.dart

+    (WidgetTester wt) async {
+      await init(wt);
+
+      await wt.tapAndSettle(find.appDropdownButtonWithText('Pipeline Options'));


Suggested change

await wt.tapAndSettle(find.appDropdownButtonWithText('Pipeline Options'));

await wt.openPipelineOptions();

?

alexeyinkin · 2023-01-24T10:44:01Z

playground/frontend/integration_test/standalone_change_pipeline_options_and_run_test.dart

+      await wt.tap(find.runOrCancelButton());
+      await Future.delayed(const Duration(milliseconds: 300));
+
+      await wt.tapAndSettle(find.runOrCancelButton());


Add a comment that cancelling is just for speed.

alexeyinkin · 2023-01-24T11:44:08Z

playground/frontend/integration_test/standalone_example_selector_test.dart

+  if (examples.isEmpty) {
+    return true;
+  }


Delete or explain.

alexeyinkin · 2023-01-24T11:47:21Z

playground/frontend/integration_test/standalone_example_selector_test.dart

+
+  return categories
+      .map((e) => e.examples.length)
+      .reduce((value, element) => value + element);


Suggested change

.reduce((value, element) => value + element);

.reduce((a, b) => a + b);

done. Thanks

alexeyinkin · 2023-01-24T11:53:13Z

playground/frontend/playground_components/lib/src/controllers/playground_controller.dart

+    notifyListeners();
+  }
+
+  void showAutocompleter() {


Suggested change

void showAutocompleter() {

void showSuggestions() {

alexeyinkin · 2023-01-24T11:56:49Z

playground/frontend/playground_components/lib/src/repositories/code_repository.dart

    'Something went wrong. Please try again later or create a GitHub issue';
 const kProcessingStartedText = 'The processing has started\n';
+const kProcessingStartedOptionsText =
+    'The processing has started with pipeline options: ';


Suggested change

'The processing has started with pipeline options: ';

'The processing has been started with the pipeline options: ';

alexeyinkin · 2023-01-24T11:59:44Z

playground/frontend/playground_components/lib/src/util/logical_keyboard_key.dart

+
+import 'native_platform.dart';
+
+extension LogicalKeyboardKeyExtension on LogicalKeyboardKey {


Suggested change

extension LogicalKeyboardKeyExtension on LogicalKeyboardKey {

class LogicalKeyboardKeyExtension {

alexeyinkin · 2023-01-26T10:19:13Z

playground/frontend/integration_test/common/common_finders.dart

    return byType(MoreActions);
  }

+  Finder pipelineOptions() {


Suggested change

Finder pipelineOptions() {

Finder pipelineOptionsDropdown() {

alexeyinkin · 2023-01-26T10:23:12Z

playground/frontend/integration_test/common/finder.dart

+  Finder verticallyAt(int index, WidgetTester wt) =>
+      _alignedIndexAt(index, Axis.vertical, wt);
+
+  Finder _alignedIndexAt(int index, Axis axis, WidgetTester wt) {


nthOnAxis or atIndexOnAxis?

alexeyinkin · 2023-01-26T10:28:48Z

playground/frontend/integration_test/common/finder.dart

+    if (a == b) {
+      return 0;
+    } else if (a > b) {
+      return 1;
+    } else {
+      return -1;
+    }


return (a - b).sign.toInt();

alexeyinkin · 2023-01-26T10:32:48Z

playground/frontend/integration_test/standalone_cancel_running_example_test.dart

-    //ignore
-  }
+
+  await wt.wait(duration);


Investigate.

This worked for me instead, and the test is green:

await wt.pump(); await Future.delayed(duration);

Can this be used instead of this function? If not, then why?

this approach freezes main isolate (watch the animation on the button with both approaches)

To me this is a lesser evil than inventing a method with a vague name without being sure how exactly it does what it does. We can just test the result.

What is the definition of "freeze"?

I believe it is impossible to put the thread to sleep in JavaScript.
I guess what appears "frozen" is just animations not ticking or ticking but not rendering.

If pump() ticks animations once and schedules a render, then for the test purpose there technically is no difference between calling it once vs calling it in a loop, it's just that with the loop we are visually satisfied with smooth animation at the cost of active waiting and complexity. I suggest keeping things simple.

added pumpAndSettleNoException

alexeyinkin · 2023-02-14T09:26:27Z

A successful run of this test in GitHub workflow: https://github.com/apache/beam/actions/runs/4172006277/jobs/7222584726

…25329_fix-cors-issue-when

…25329_fix-cors-issue-when-no-internet

* Refactor output tabs, test embedded playground (apache#25136) * Clean up (apache#25136)

damondouglas

@pabloem LGTM

pabloem · 2023-03-09T23:32:04Z

lgtm thanks y'all!

* Integration test to load the default example of the default SDK and change the example (apache#24730) (apache#24729) * Fix formatting and README (apache#24730) * Support collection v1.17.0 (apache#24730) * LoadingIndicator on chaning examples, remove duplicating licenses (apache#24730) * Add a missing license header (apache#24730) * Integration test for changing SDK and running code (apache#24779) (#382) * Integration test for changing SDK and running code (apache#24779) * Rename an integration test (apache#24779) * Use enum to switch SDK in integration test (apache#24779) * Find SDK in a dropdown by key (apache#24779) * Add a TODO (apache#24779) * Fix exports (apache#24779) * Issue24779 integration changing sdk from 24370 (#387) * Integration test for changing SDK and running code (apache#24779) * Rename an integration test (apache#24779) * Use enum to switch SDK in integration test (apache#24779) * Find SDK in a dropdown by key (apache#24779) * Add a TODO (apache#24779) * Fix exports (apache#24779) * Integration tests miscellaneous UI (#383) * miscellaneous ui integration tests * reverted pubspec.lock * gradle tasks ordered alhpabetically * integration tests refactoring * clean code * integration tests miscellaneous ui fix pr * rename method * added layout adaptivity * A minor cleanup (apache#24779) Co-authored-by: Dmitry Repin <mr.malarg@gmail.com> * integration tests run and editing * example selector test * minor fixes * rat * fix pr * minor * minor * rat * integration test finder written * integration test minor fixes * minor fixes * removed comment * minor fixes * playground integration tests minor fixes * integration test pumpAnSettleNoException * integration test shortcut refactor * integration test another changing shortcuts running * upgrade to flutter 3.7.1 * workaround comment * playground frontend updated major versions * issues 25329 25331 25336 * 25329 extract connectivity extension to separate file * Upgrade Flutter to 3.7.3 in integration tests (apache#24730) * Fix integration test (apache#24730) * fix cors issue and added mouse scroll to tags * Upgrade Flutter in Dockerfile (apache#24720) * sorting moved to model * sorting moved to model * sorting moved to model * bugs fix * issue 25278 * fix pr * quites fix in en.yaml * Fix not loading default example (apache#25528) * fix compile error * Refactor output tabs, test embedded playground (apache#25136) (#439) * Refactor output tabs, test embedded playground (apache#25136) * Clean up (apache#25136) * Change example paths to IDs in integration tests * Panning the graph tab (apache#25118) --------- Co-authored-by: Alexey Inkin <alexey.inkin@akvelon.com> Co-authored-by: alexeyinkin <leha@inkin.ru>

alexeyinkin and others added 14 commits December 20, 2022 17:56

Integration test to load the default example of the default SDK and c…

933bb24

…hange the example (apache#24730) (apache#24729)

Fix formatting and README (apache#24730)

acd76ef

Support collection v1.17.0 (apache#24730)

07e78c6

LoadingIndicator on chaning examples, remove duplicating licenses (ap…

5ffd808

…ache#24730)

Add a missing license header (apache#24730)

9bb0268

Merge branch 'master' into issue24730_integration_changing-example

27c870c

Merge branch 'master' into issue24730_integration_changing-example

cc8a998

integration tests run and editing

8d4f85f

Merge branch 'master' into playground_integration_test_run_and_editing

d9c23a6

example selector test

7dbd08b

minor fixes

4fe215d

rat

0e2a469

alexeyinkin suggested changes Jan 18, 2023

View reviewed changes

Malarg added 3 commits January 24, 2023 10:24

fix pr

a33d058

minor

b350351

Merge branch 'master' into playground_integration_test_run_and_editing

a9a5e88

github-actions bot added the learning label Jan 24, 2023

Malarg added 2 commits January 24, 2023 11:58

minor

01fe5a7

rat

4275eb6

alexeyinkin suggested changes Jan 24, 2023

View reviewed changes

Malarg added 5 commits January 26, 2023 09:47

integration test finder written

7316da0

Merge branch 'master' into playground_integration_test_run_and_editing

17b767a

integration test minor fixes

c8deff8

minor fixes

e3fcab5

removed comment

77f372f

alexeyinkin suggested changes Jan 26, 2023

View reviewed changes

Malarg added 2 commits January 27, 2023 14:02

minor fixes

52ad461

Merge branch 'master' into playground_integration_test_run_and_editing

63f8faa

fix cors issue and added mouse scroll to tags

916a966

alexeyinkin and others added 18 commits February 14, 2023 14:43

Upgrade Flutter in Dockerfile (apache#24720)

cd83c1f

sorting moved to model

ffa95e7

sorting moved to model

eb33795

sorting moved to model

399a80a

Merge branch 'master' into playground_integration_test_run_and_editing

0fe9113

bugs fix

6080a4b

issue 25278

b7b14b4

fix pr

2ca302e

quites fix in en.yaml

781de4f

Fix not loading default example (apache#25528)

694e22e

Merge branch 'master' into issue25329

284ed49

Merge branch 'playground_integration_test_run_and_editing' into issue…

ccf8c3b

…25329_fix-cors-issue-when

Merge branch 'master' into playground_integration_test_run_and_editing

03f7a5f

Merge branch 'playground_integration_test_run_and_editing' into issue…

28449be

…25329_fix-cors-issue-when-no-internet

fix compile error

6e4581b

Refactor output tabs, test embedded playground (apache#25136) (#439)

3aa9fec

* Refactor output tabs, test embedded playground (apache#25136) * Clean up (apache#25136)

Change example paths to IDs in integration tests

1e17d04

Merge branch 'master' into playground_integration_test_run_and_editing

dd1d275

alexeyinkin mentioned this pull request Mar 6, 2023

[Playground] GetMetadata() endpoint #25610

Merged

3 tasks

Panning the graph tab (apache#25118)

215ddf0

github-actions bot added the website label Mar 7, 2023

damondouglas approved these changes Mar 9, 2023

View reviewed changes

pabloem merged commit 48c143d into apache:master Mar 9, 2023

alexeyinkin mentioned this pull request Mar 22, 2023

[Bug]: If any default example fails to load, the default example of the default SDK is not shown #25528

Closed

15 tasks

	expect(startSource != controller.source, true);
	expect(controller.source, isNot(startSource));


		expect(startSource != controller.source, true);

		await wt.runShortcut(controller.resetShortcut.shortcuts.keys);


		_checkIfRawTextCorrect('--some test --some2 test2');

		await wt.tapAndSettle(find.pipelineOptionsOptionsTab());

	Future<void> _checkCodeHighlighting(WidgetTester wt) async {
	Future<void> _expectMoreThanOneColor(WidgetTester wt) async {

		await wt.tapAndSettle(find.exampleSelector());
		await wt.tapAndSettle(find.exampleSelector());

		await _checkFilteringExamplesByTags(wt);
		await _checkFilteringExamplesBySearchString(wt);

	await wt.tapAndSettle(find.appDropdownButtonWithText('Pipeline Options'));
	await wt.openPipelineOptions();

	.reduce((value, element) => value + element);
	.reduce((a, b) => a + b);

	'The processing has started with pipeline options: ';
	'The processing has been started with the pipeline options: ';


		import 'native_platform.dart';

		extension LogicalKeyboardKeyExtension on LogicalKeyboardKey {

	extension LogicalKeyboardKeyExtension on LogicalKeyboardKey {
	class LogicalKeyboardKeyExtension {

	Finder pipelineOptions() {
	Finder pipelineOptionsDropdown() {

Conversation

Malarg commented Jan 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Actions Tests Status (on master branch)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Malarg commented Jan 17, 2023 •

edited

Loading