Skip to content

[CdapIO] Complete examples for CDAP ServiceNow plugins#24590

Merged
johnjcasey merged 3 commits intoapache:masterfrom
akvelon:cdap-servicenow-examples
Dec 14, 2022
Merged

[CdapIO] Complete examples for CDAP ServiceNow plugins#24590
johnjcasey merged 3 commits intoapache:masterfrom
akvelon:cdap-servicenow-examples

Conversation

@Amar3tto
Copy link
Copy Markdown
Collaborator

@Amar3tto Amar3tto commented Dec 8, 2022 •
edited
Loading

Resolves #24961

Added examples for the following CDAP ServiceNow plugins:

  • Batch Source

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Dec 8, 2022
@Amar3tto Amar3tto mentioned this pull request Dec 8, 2022
Closed
4 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 8, 2022 •
edited
Loading

Codecov Report

Merging #24590 (1a9d8a0) into master (f1fcf0a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24590   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files         719      719           
  Lines       97137    97137           
=======================================
+ Hits        71252    71253    +1     
+ Misses      24537    24536    -1     
  Partials     1348     1348
Flag Coverage Δ
python 82.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/transforms/periodicsequence.py 97.01% <0.00%> (-1.50%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.16%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Amar3tto Amar3tto marked this pull request as ready for review December 8, 2022 13:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 8, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label build.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto Amar3tto force-pushed the cdap-servicenow-examples branch from e016491 to a506d51 Compare December 12, 2022 07:48
@github-actions github-actions bot added io and removed io labels Dec 12, 2022
@github-actions github-actions bot added io and removed io labels Dec 12, 2022
@github-actions github-actions bot added io and removed io labels Dec 12, 2022
@Amar3tto
Copy link
Copy Markdown
Collaborator Author

Amar3tto commented Dec 13, 2022

Run Java_Kafka_IO_Direct PreCommit

@elizaveta-lomteva
Copy link
Copy Markdown
Contributor

elizaveta-lomteva commented Dec 13, 2022 •
edited
Loading

R: @johnjcasey

We divided our CDAP examples PR by example (service). This is the first one ready for review.
Could you please take the time to review it?

Thanks in advance!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@johnjcasey johnjcasey merged commit 70fd69f into apache:master Dec 14, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
@Amar3tto @lostluck
[CdapIO] Complete examples for CDAP ServiceNow plugins (apache#24590)
3ced692 
* Add examples for Cdap ServiceNow plugins

* Move common classes to Examples Cdap module

* Fix readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnjcasey johnjcasey johnjcasey approved these changes

Assignees

No one assigned

Labels

build examples io java Next Action: Reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Implement CdapIO connector for Java

3 participants

@Amar3tto @elizaveta-lomteva @johnjcasey