Run go fmt over full go directory with go 1.19#24525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24525 +/- ##
==========================================
- Coverage 73.38% 73.38% -0.01%
==========================================
Files 719 719
Lines 97206 97206
==========================================
- Hits 71335 71332 -3
- Misses 24524 24526 +2
- Partials 1347 1348 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| // - Beam's default reflection based reflectx.Func shim | ||
| // - A Type assertion specialized reflectx.Func shim |
There was a problem hiding this comment.
Note that this is a change in behavior from 1.18 -> 1.19. 1.19 won't let you have subindented lists. Importantly, however, the following:
// * foo
// * bar
// * baz
has always rendered as:
* foo
* bar
* baz
in the godoc anyways (indents weren't maintained). I fixed a few of these cases in my second commit in this PR and called them out with comments. I left this one since I don't think the indents add anything.
There was a problem hiding this comment.
Technically the sub indents were describing reflectx.Func and reflectx.FuncNxM respectively, so it was intending to serve a purpose. In this case, I agree that there's no reason to fuss over it since it was already broken.
| // - Java | ||
| // - Vendored Module: beam-sdks-java-extensions-schemaio-expansion-service | ||
| // - Run via Gradle: ./gradlew :sdks:java:extensions:schemaio-expansion-service:runExpansionService | ||
| // - Reference Class: org.apache.beam.sdk.io.gcp.bigquery.BigQuerySchemaIOProvider and |
There was a problem hiding this comment.
I updated this so that it renders as:
Java:
* bullets
* ...
* ...
instead of the way it currently renders:
* Java
* bullets
* ...
* ...
Current rendering here - https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.43.0/go/pkg/beam/io/xlang/bigqueryio#hdr-Setup
| // - Vendored Module: beam-sdks-java-io-debezium-expansion-service | ||
| // - Run via Gradle: ./gradlew :sdks:java:io:debezium:expansion-service:shadowJar | ||
| // java -jar <path-to-debezium-jar> <port> | ||
| // - Reference Class: org.apache.beam.io.debezium.DebeziumIO |
There was a problem hiding this comment.
I updated this for the same reason as the previous (bigquery one)
| // - Vendored Module: beam-sdks-java-extensions-schemaio-expansion-service | ||
| // - Run via Gradle: ./gradlew :sdks:java:extensions:schemaio-expansion-service:build | ||
| // java -jar <location_of_jar_file_generated_from_above> <port> | ||
| // - Reference Class: org.apache.beam.sdk.io.jdbc.JdbcIO |
There was a problem hiding this comment.
Same as bigquery/debezium
| // - Reference Class: org.apache.beam.sdk.io.kafka.KafkaIO | ||
| // - Vendored Module: beam-sdks-java-io-expansion-service | ||
| // - Run via Gradle: ./gradlew :sdks:java:io:expansion-service:runExpansionService | ||
| // - Reference Class: org.apache.beam.sdk.io.kafka.KafkaIO |
There was a problem hiding this comment.
Same as bigquery/debezium/jdbc
| // /Users/herohde/go/src/github.com/apache/beam/sdks/go/pkg/beam/runners/beamexec/main.go (skip: 2) | ||
| // * /Users/herohde/go/src/github.com/apache/beam/sdks/go/examples/wordcount/wordcount.go (skip: 3) | ||
| // /usr/local/go/src/runtime/proc.go (skip: 4) // not always present | ||
| // /usr/local/go/src/runtime/asm_amd64.s (skip: 4 or 5) |
There was a problem hiding this comment.
This was very broken before - https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.43.0/go/pkg/beam/runners/universal/runnerlib#BuildWorkerBinary
Now it renders as:
|
R: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
lostluck
left a comment
There was a problem hiding this comment.
Thanks for getting ahead on this!
We can now move the Github action to use 1.19+.
This unblocks using go 1.19 for the Action unit tests & formatting check.
Fixes #24190
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.