Add enableGzipHttpCompression and enableBatchLogs options to SplunkIO#24197
Merged
johnjcasey merged 1 commit intoapache:masterfrom Nov 17, 2022
Merged
Add enableGzipHttpCompression and enableBatchLogs options to SplunkIO#24197johnjcasey merged 1 commit intoapache:masterfrom
johnjcasey merged 1 commit intoapache:masterfrom
Conversation
c342e54 to
fee73b1
Compare
johnjcasey
reviewed
Nov 16, 2022
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEventWriter.java
Show resolved
Hide resolved
johnjcasey
reviewed
Nov 16, 2022
Contributor
johnjcasey
left a comment
There was a problem hiding this comment.
LGTM other than some cleanup
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
add enableBatchLogs as SplunkIO option spotless fix issue with setEnableBatchLogs
fee73b1 to
5708d5e
Compare
johnjcasey
approved these changes
Nov 17, 2022
andreigurau
added a commit
to andreigurau/beam
that referenced
this pull request
Nov 17, 2022
add enableBatchLogs as SplunkIO option spotless fix issue with setEnableBatchLogs
andreigurau
added a commit
to andreigurau/beam
that referenced
this pull request
Nov 17, 2022
fix test Add error reporting for BatchConverter match failure (apache#24022) * add error reporting for BatchConverters * Test pytorch * Finish up torch tests * yapf * yapf * Remove else Update automation to use Go 1.19 (apache#24175) Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com> Fix broken json for notebook (apache#24183) Using Teardown context instead of deprecated finalize (apache#24180) * Using Teardown context instead of deprecated finalize * making function public Co-authored-by: Scott Strong <scott.strong@wunderkind.co> [Python]Support pipe operator as Union (PEP -604) (apache#24106) Fixes apache#21972 Add custom inference function support to the PyTorch model handler (apache#24062) * Initial type def and function signature * [Draft] Add custom inference fn support to Pytorch Model Handler * Formatting * Split out default * Remove Keyed version for testing * Move device optimization * Make default available for import, add to test classes * Remove incorrect default from keyed test * Keyed impl * Fix device arg * custom inference test * formatting * Add helpers to define custom inference functions using model methods * Trailing whitespace * Unit tests * Fix incorrect getattr syntax * Type typo * Fix docstring * Fix keyed helper, add basic generate route * Modify generate() to be different than forward() * formatting * Remove extra generate() def Strip FGAC database role from changestreams metadata requests (apache#24177) Co-authored-by: Doug Judd <nuggetwheat@google.com> Updated README of Interactive Beam Removed deprecated cache_dir runner param in favor of the cache_root global option. Minor update Fix arguments to checkState in BatchViewOverrides Re-use serializable pipeline options when already available (apache#24192) Fix Python PostCommit Example CustomPTransformIT on portable (apache#24159) * Fix Python PostCommit Examples on portable * Fix custom_ptransform pipeline options gets modified * Specify flinkConfDir revert upgrade to go 1.19 for action unit tests (apache#24189) Use only ValueProviders in SpannerConfig (apache#24156) [Tour of Beam] [Frontend] Content tree URLs (apache#23776) * Content tree navigation (apache#23593) Unit content navigation (apache#23593) Update URL on node click (apache#23593) Active unit color (apache#23593) removeListener in unit (apache#23593) First unit is opened on group title click (apache#23593) WIP by Alexey Inkin (apache#23593) selectedUnitColor (apache#23593) Unit borderRadius (apache#23593) RegExp todo (apache#23593) added referenced collection package to remove warning (apache#23593) small refinement (apache#23593) expand on group tap, padding, openNode (apache#23593) group expansion bug fix (apache#23593) selected & unselected progress indicators (apache#23593) * AnimatedBuilders instead of StatefulWidgets in unit & group (apache#23593) * fixed _getNodeAncestors (apache#23593) * get sdkId (apache#23593) * addressing comments (apache#23593) * sdkId getter & StatelessExpansionTile (apache#23593) * expand & collapse group (apache#23593) * StatelessExpansionTile (apache#23593) * license (apache#23593) * ValueChanged and ValueKey in StatelessExpansionTile (apache#23593) Co-authored-by: darkhan.nausharipov <darkhan.nausharipov@kzn.akvelon.com> Co-authored-by: Alexey Inkin <alexey.inkin@akvelon.com> refs: issue-24196, fix broken hyperlink Add a reference to Java RunInference example Python TextIO Performance Test (apache#23951) * Python TextIO Performance Test * Add filebasedio_perf_test module for unified test framework for Python file-based IOs * Fix MetricsReader publishes metrics duplicately if more than one load test declared. This is because MetricsReader.publishers was static class variable * Fix pylint * Distribute Python performance tests random time at a day instead of all at 3PM * Add information about length conversion Fix PythonLint (apache#24219) Bump loader-utils from 1.4.1 to 1.4.2 in /sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel (apache#24191) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Temporary update Python RC validation job updates updates Uses _all to follow alias/datastreams when estimating index size Fixes apache#24117 Adds test for following aliases when estimating index size Bump github.com/aws/aws-sdk-go-v2/config from 1.18.0 to 1.18.1 in /sdks (apache#24222) Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.18.0...config/v1.18.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Add enableGzipHttpCompression option to SplunkIO (apache#24197) add enableBatchLogs as SplunkIO option spotless fix issue with setEnableBatchLogs
prodriguezdefino
pushed a commit
to prodriguezdefino/beam-pabs
that referenced
this pull request
Nov 18, 2022
add enableBatchLogs as SplunkIO option spotless fix issue with setEnableBatchLogs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transferring over some SplunkIO options (
enableGzipHttpCompressionandenableBatchLogs) from the SplunkIO implementation in DataflowTemplates here, so that DataflowTemplates can use Beam's SplunkIO implementation (there is an inconsistency in that classic templates use the DataflowTemplates implementation while flex templates use Beam's implementation, and Beam's implementation seems to be missing some options).The
rootCaCertificatePathoption will be done in a separate PR, since adding that option will require more changes than the above two options.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.