Fix python examples tests not running in Dataflow by benEng · Pull Request #23546 · apache/beam

benEng · 2022-10-07T21:04:52Z

Resolves #22983

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

benEng · 2022-10-07T21:08:25Z

Run Python Examples_Direct

benEng · 2022-10-07T21:08:56Z

Run Python Examples_Dataflow

benEng · 2022-10-07T21:10:23Z

@tvalentyn could you help me to approve running workflows to test my fixes?

benEng · 2022-10-07T21:25:09Z

Run Python Examples_Flink

benEng · 2022-10-07T21:25:25Z

Run Python Examples_Spark

codecov · 2022-10-07T21:57:44Z

Codecov Report

Merging #23546 (08e88a8) into master (9192cb9) will decrease coverage by 0.36%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master   #23546      +/-   ##
==========================================
- Coverage   73.46%   73.09%   -0.37%     
==========================================
  Files         718      729      +11     
  Lines       95884    98231    +2347     
==========================================
+ Hits        70438    71799    +1361     
- Misses      24135    25121     +986     
  Partials     1311     1311

Flag	Coverage Δ
python	`82.36% <20.00%> (-0.86%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdks/python/apache_beam/testing/test_utils.py	`90.52% <18.18%> (-9.48%)`	⬇️
sdks/python/apache_beam/examples/complete/tfidf.py	`73.43% <25.00%> (-24.95%)`	⬇️
...python/apache_beam/examples/complete/distribopt.py	`0.00% <0.00%> (-98.57%)`	⬇️
...hon/apache_beam/examples/cookbook/mergecontacts.py	`23.21% <0.00%> (-73.22%)`	⬇️
...he_beam/examples/cookbook/multiple_output_pardo.py	`37.50% <0.00%> (-58.34%)`	⬇️
...python/apache_beam/examples/wordcount_debugging.py	`38.77% <0.00%> (-57.15%)`	⬇️
...python/apache_beam/examples/dataframe/wordcount.py	`38.46% <0.00%> (-53.85%)`	⬇️
...s/python/apache_beam/examples/wordcount_minimal.py	`40.74% <0.00%> (-51.86%)`	⬇️
sdks/python/apache_beam/examples/wordcount.py	`48.27% <0.00%> (-44.83%)`	⬇️
...apache_beam/examples/cookbook/custom_ptransform.py	`52.38% <0.00%> (-42.86%)`	⬇️
... and 62 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

benEng · 2022-10-10T18:09:56Z

Run Python Examples_Spark

benEng · 2022-10-11T19:54:24Z

@tvalentyn I've fixed some of the examples so those can run in Dataflow, but a couple of them are failing https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Dataflow_PR/20/ not sure why those are having differences in the assertions, do you have some insight to fix them easily or do you think it is better to sickbay those for the Dataflow suite and fill a new issue?

benEng · 2022-10-11T19:59:43Z

Examples running in Direct https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Direct_PR/18/
Dataflow https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Dataflow_PR/21/

tvalentyn · 2022-10-11T20:00:00Z

Filing issues and sickbaying sounds good

tvalentyn · 2022-10-11T20:00:12Z

thank you

benEng · 2022-10-12T19:59:37Z

Run Python Examples_Dataflow

github-actions · 2022-10-12T23:05:07Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @TheNeuralBit for label python.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

TheNeuralBit

Thank you! I have a few suggestions

TheNeuralBit · 2022-10-14T18:31:26Z

sdks/python/apache_beam/examples/complete/tfidf.py

+try:
+  from apache_beam.io.gcp import gcsio
+except ImportError:
+  gcsio = None


Does this actually protect us? It looks like this would just change the error to a more confusing one: None has no attribure GcsIO, when gcsio is used. I think just letting the ImportError raise would be preferable.

Alternatively we could add a skipIf(gcsio is None), but that might lead to us unintentionally skipping it indefinitely.

TheNeuralBit · 2022-10-14T18:36:57Z

sdks/python/apache_beam/examples/complete/distribopt_test.py

+  logging.info('Creating file: %s', path)
+  gcs = gcsio.GcsIO()
+  with gcs.open(path, 'w') as f:
+    f.write(str.encode(contents, 'utf-8'))


nit: I think it would be better if these utilities used the Filesystems API, see here for an example:

beam/sdks/python/apache_beam/examples/dataframe/taxiride_it_test.py

Lines 93 to 100 in 45cc085

def read_csv(path):

with FileSystems.open(path) as fp:

return pd.read_csv(fp)

result = pd.concat(

read_csv(metadata.path) for metadata in FileSystems.match(

[f'{self.output_path}*'])[0].metadata_list)

result = result.sort_values('Borough').reset_index(drop=True)

It would also be good to extract these out into testing.utils rather than copying them.

Thanks, @TheNeuralBit, I applied some of your suggestions

benEng · 2022-10-20T20:23:37Z

Run Python Examples_Dataflow

benEng · 2022-10-20T20:23:52Z

Run Python Examples_Direct

github-actions · 2022-10-29T12:13:36Z

Reminder, please take a look at this pr: @TheNeuralBit

benEng · 2022-11-01T15:29:27Z

Run Python PreCommit

TheNeuralBit · 2022-11-01T17:43:35Z

Run Python PreCommit

TheNeuralBit · 2022-11-01T17:46:02Z

Run Python 3.8 PostCommit

benEng · 2022-11-01T21:14:53Z

Thanks, @TheNeuralBit!

* Fix tests for examples not running in Dataflow * Remove unused test * Add todos to enable test for Dataflow * Refactor utilities functions to create and read files * Fix lint errors * Fix lint errors and skip tests that require gcsio and is not available * Refactor read file function and remove gcsio dependency

Fix tests for examples not running in Dataflow

48046bd

github-actions bot added examples python labels Oct 7, 2022

Remove unused test

7a46a3b

Merge branch 'master' into bug-python-examples

f8756da

Add todos to enable test for Dataflow

c90dc41

benEng marked this pull request as ready for review October 12, 2022 21:59

github-actions bot added the Next Action: Reviewers label Oct 12, 2022

TheNeuralBit reviewed Oct 14, 2022

View reviewed changes

Refactor utilities functions to create and read files

6442c68

Fix lint errors

f848468

TheNeuralBit self-requested a review October 20, 2022 21:55

benEng added 2 commits October 20, 2022 17:09

Fix lint errors and skip tests that require gcsio and is not available

c54eb2e

Refactor read file function and remove gcsio dependency

08e88a8

github-actions bot added the slow-review label Oct 29, 2022

TheNeuralBit approved these changes Nov 1, 2022

View reviewed changes

github-actions bot removed the slow-review label Nov 1, 2022

TheNeuralBit merged commit c6f64bb into apache:master Nov 1, 2022

Abacn mentioned this pull request Nov 14, 2022

Fix Python PostCommit Example CustomPTransformIT on portable #24159

Merged

4 tasks

	def read_csv(path):
	with FileSystems.open(path) as fp:
	return pd.read_csv(fp)

	result = pd.concat(
	read_csv(metadata.path) for metadata in FileSystems.match(
	[f'{self.output_path}*'])[0].metadata_list)
	result = result.sort_values('Borough').reset_index(drop=True)

Conversation

benEng commented Oct 7, 2022

GitHub Actions Tests Status (on master branch)

Uh oh!

benEng commented Oct 7, 2022

Uh oh!

benEng commented Oct 7, 2022

Uh oh!

benEng commented Oct 7, 2022

Uh oh!

benEng commented Oct 7, 2022

Uh oh!

benEng commented Oct 7, 2022

Uh oh!

codecov bot commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

benEng commented Oct 10, 2022

Uh oh!

benEng commented Oct 11, 2022

Uh oh!

benEng commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tvalentyn commented Oct 11, 2022

Uh oh!

tvalentyn commented Oct 11, 2022

Uh oh!

benEng commented Oct 12, 2022

Uh oh!

github-actions bot commented Oct 12, 2022

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

TheNeuralBit Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

TheNeuralBit Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

benEng Oct 20, 2022

Choose a reason for hiding this comment

Uh oh!

benEng commented Oct 20, 2022

Uh oh!

benEng commented Oct 20, 2022

Uh oh!

github-actions bot commented Oct 29, 2022

Uh oh!

benEng commented Nov 1, 2022

Uh oh!

TheNeuralBit commented Nov 1, 2022

Uh oh!

TheNeuralBit commented Nov 1, 2022

Uh oh!

benEng commented Nov 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 7, 2022 •

edited

Loading

benEng commented Oct 11, 2022 •

edited

Loading