Skip to content

Update cibuildwheel#23024

Merged
tvalentyn merged 4 commits intoapache:masterfrom
AnandInguva:update-cibuildwheel
Sep 14, 2022
Merged

Update cibuildwheel#23024
tvalentyn merged 4 commits intoapache:masterfrom
AnandInguva:update-cibuildwheel

Conversation

@AnandInguva
Copy link
Copy Markdown
Contributor

@AnandInguva AnandInguva commented Sep 3, 2022 •
edited
Loading

Update cibuildwheel to a latest version and exclude building the muslinux wheels

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2022 •
edited
Loading

Codecov Report

Merging #23024 (221e3fb) into master (31561e2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 221e3fb differs from pull request most recent head 6275c35. Consider uploading reports for the commit 6275c35 to get more accurate results

@@            Coverage Diff             @@
##           master   #23024      +/-   ##
==========================================
- Coverage   73.71%   73.69%   -0.02%     
==========================================
  Files         714      714              
  Lines       95240    95240              
==========================================
- Hits        70203    70190      -13     
- Misses      23740    23753      +13     
  Partials     1297     1297
Flag Coverage Δ
python 83.51% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/ml/inference/base.py 95.58% <100.00%> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.57% <0.00%> (-1.70%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...eam/runners/interactive/interactive_environment.py 91.71% <0.00%> (-0.31%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) ⬇️
sdks/python/apache_beam/runners/common.py 88.59% <0.00%> (-0.13%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 89.40% <0.00%> (+1.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva AnandInguva changed the title [WIP]Update cibuildwheel Update cibuildwheel Sep 3, 2022
@AnandInguva AnandInguva marked this pull request as ready for review September 3, 2022 19:21
@AnandInguva
Copy link
Copy Markdown
Contributor Author

AnandInguva commented Sep 3, 2022

R @tvalentyn

AnandInguva
AnandInguva commented Sep 3, 2022
View reviewed changes
sdks/python/apache_beam/ml/inference/base.py Outdated
from the inference."""
PredictionResult.example.__doc__ = """The input example."""
PredictionResult.inference.__doc__ = """Results for the inference on the model
PredictionResult.inference.__doc__ = """Results fo r the inference on the model
Copy link
Copy Markdown
Contributor Author

@AnandInguva AnandInguva Sep 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this once this PR gets LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @TheNeuralBit for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva
Copy link
Copy Markdown
Contributor Author

AnandInguva commented Sep 6, 2022

stop reviewer notifications

tvalentyn
tvalentyn approved these changes Sep 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue to add support for new wheel architecture (and add a TODO), or increase the timeout. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 6, 2022

Stopping reviewer notifications for this pull request: requested by reviewer

@AnandInguva AnandInguva mentioned this pull request Sep 6, 2022
Open
@AnandInguva
Copy link
Copy Markdown
Contributor Author

AnandInguva commented Sep 6, 2022

@tvalentyn added a TODO with issue link. PTAL

@github-actions github-actions bot removed the python label Sep 6, 2022
@tvalentyn tvalentyn merged commit 60c4fae into apache:master Sep 14, 2022
@AnandInguva AnandInguva mentioned this pull request Nov 11, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvalentyn tvalentyn tvalentyn approved these changes

Assignees

No one assigned

Labels

build Next Action: Reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnandInguva @tvalentyn