[BEAM-14116] Catch MonitoringInfoMetricName null keys or values in the constructor #17094
Conversation
|
R: @lukecwik |
|
R: @scwhittle |
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
...oogle-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java
Outdated
Show resolved
Hide resolved
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
|
CC: @robertwb |
|
|
||
| @Override | ||
| public String getName() { | ||
| if (labels.containsKey(MonitoringInfoConstants.Labels.NAME)) { |
There was a problem hiding this comment.
nit: ditto on not looking in the map multiple times
|
Run Java PreCommit |
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
Run Portable_Python PreCommit |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Manually kicked off Java PreCommit for this PR https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/21736 because the github comments aren't making it to Jenkins |
|
Run Java PreCommit |
|
Java PreCommit finally passed |
|
@youngoli It looks like this change uncovered additional cases. We thought we caught the cases where this was happening but additional integration testing within Google caught that this fails for Datastore as well. Filed https://issues.apache.org/jira/browse/BEAM-14179 |
…ecution PR apache#16547 added handling for null ProjectIDs on command line execution, but did not handle the possibility of null ProjectIDs in template execution. PR apache#17094 added nullness checks in MonitoringInfoMetricNames, which then triggered NPEs if the ProjectID was not specified during a template execution.
Also fix possibly null field