Extract PubsubMessage transforms in PubsubMessages and use them to add a compatability transform for Pub/Sub Lite. #14917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a compatability transform for Pub/Sub Lite.
Contributor
Author
|
R: @chamikaramj |
…d a compatability transform for Pub/Sub Lite.
kennknowles
reviewed
Jun 2, 2021
| * | ||
| * <p>Will fail the pipeline if a message has multiple attributes per map key. | ||
| */ | ||
| public static PTransform<PCollection<? extends SequencedMessage>, PCollection<PubsubMessage>> |
Member
There was a problem hiding this comment.
Can you write this as a composite transform? Same logic, but in the expand method. A bit of boilerplate that helps out UIs and metrics, etc.
Member
|
@dpcollins-google - Would you be able to respond to Kenn's comment when you get a chance? |
dpcollins-google
added a commit
to googleapis/java-pubsublite
that referenced
this pull request
Jun 24, 2021
Also fix concerns from apache/beam#14917 surrounding direct use of MapElements. Also add dependencyManagement section to beam io pom to fix upper bound deps issues.
Contributor
Author
|
Closing in preference to #15076 |
dpcollins-google
added a commit
to googleapis/java-pubsublite
that referenced
this pull request
Jul 29, 2021
* feat: Update CloudPubsubChecks to CloudPubsubTransforms Also fix concerns from apache/beam#14917 surrounding direct use of MapElements. Also add dependencyManagement section to beam io pom to fix upper bound deps issues. * fix: Add pubsub proto dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.