[BEAM-8755] Upgrade google-cloud-bigquerystorage to one from libraries-bom (1.17.0)#14563
Closed
suztomo wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-8755] Upgrade google-cloud-bigquerystorage to one from libraries-bom (1.17.0)#14563suztomo wants to merge 1 commit intoapache:masterfrom
suztomo wants to merge 1 commit intoapache:masterfrom
Conversation
suztomo
commented
Apr 16, 2021
| appendRequestBuilder = appendRequestBuilder.setOffset(Int64Value.of(offset)); | ||
| } | ||
| return streamWriter.append(appendRequestBuilder.build()); | ||
| return streamWriter.append(rows, offset); |
Contributor
Author
There was a problem hiding this comment.
This change ignores descriptor. What's a good migration?
https://github.com/googleapis/java-bigquerystorage/pull/924/files
Contributor
Author
There was a problem hiding this comment.
@yayi-google (I saw your name on https://github.com/googleapis/java-bigquerystorage/pull/924/files). I appreciate if you can help here. Do you know a good way to adjust this Beam code for the method removal?
(I don't use Beam or Bigquery; I just want to upgrade the library in Beam)
|
There is already another pull request from Reuven handling this.
…On Fri, Apr 16, 2021 at 8:22 AM Tomo Suzuki ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
<#14563 (comment)>:
> @@ -1138,18 +1136,7 @@ public void unpin() throws Exception {
@OverRide
public ApiFuture<AppendRowsResponse> appendRows(
long offset, ProtoRows rows, Descriptor descriptor) throws Exception {
- final AppendRowsRequest.ProtoData data =
- AppendRowsRequest.ProtoData.newBuilder()
- .setWriterSchema(
- ProtoSchema.newBuilder().setProtoDescriptor(descriptor.toProto()).build())
- .setRows(rows)
- .build();
- AppendRowsRequest.Builder appendRequestBuilder =
- AppendRowsRequest.newBuilder().setProtoRows(data).setWriteStream(streamName);
- if (offset >= 0) {
- appendRequestBuilder = appendRequestBuilder.setOffset(Int64Value.of(offset));
- }
- return streamWriter.append(appendRequestBuilder.build());
+ return streamWriter.append(rows, offset);
@yayi-google <https://github.com/yayi-google> (I saw your name on
https://github.com/googleapis/java-bigquerystorage/pull/924/files). I
appreciate if you can help here. Do you know a good way to adjust this Beam
code for the method removal?
(I don't use Beam or Bigquery; I just want to upgrade the library in Beam)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14563 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASBQVIMBQEVPUQCIKIXKZVLTJBI2TANCNFSM43AYJMCA>
.
|
Contributor
Author
|
@yayi-google Found #14548. Thank you! |
suztomo
added a commit
to suztomo/beam
that referenced
this pull request
Apr 19, 2021
The google-cloud-bigquerystorage 1.12.0 has old gax-httpjson version 0.78.0, which causes dependency conflicts. The libraries-bom 20.0.0 has google-cloud-bigquerystorage 1.17.0 but the version has removed a method used in Beam ( apache#14563). Unfortunatley even 1.17.0 does not have compatible version of gax-httpjson. Therefore, this commit fixes the dependency conflict by declaring newer gax-httpjson (version from the libraries-bom) on the sdks/java/io/google-cloud-platform module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14527 (comment) found that old google-cloud-bigquerystorage would create dependency conflicts over gax-httpjson. Let's upgrade the dependency. The latest libraries-bom 20.0.0 there has google-cloud-bigquerystorage version 1.17.0.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.