Skip to content

[BEAM-10229] Fix VideoIntelligence IT tests#11946

Merged
kamilwu merged 1 commit intoapache:masterfrom
kamilwu:fix-video-intelligence-test
Jun 9, 2020
Merged

[BEAM-10229] Fix VideoIntelligence IT tests#11946
kamilwu merged 1 commit intoapache:masterfrom
kamilwu:fix-video-intelligence-test

Conversation

@kamilwu
Copy link
Copy Markdown
Contributor

@kamilwu kamilwu commented Jun 8, 2020

VideoIntelligence IT tests use presence label annotations for comparing actual results to expected results, which is made available only when the client sets LabelDetectionConfig.model to “builtin/latest” in the request.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

Run Python 3.7 PostCommit

@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

Run Python2_PVR_Flink PreCommit

VideoIntelligence IT tests use presence label annotations for comparing actual results to expected results, which is made available only when the client sets LabelDetectionConfig.model to “builtin/latest” in the request.
@kamilwu kamilwu force-pushed the fix-video-intelligence-test branch from a7dee42 to 3ea1c64 Compare June 8, 2020 14:34
@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

Run Python 3.7 PostCommit

@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

Run PythonLint PreCommit

@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

cc: @mwalenia

@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

R: @pawelpasterz

@pawelpasterz
Copy link
Copy Markdown
Contributor

@kamilwu LGTM, thanks!

@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

Run Java PreCommit

2 similar comments
@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

Run Java PreCommit

@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 8, 2020

Run Java PreCommit

@kamilwu kamilwu merged commit 0ef1404 into apache:master Jun 9, 2020
@kamilwu kamilwu deleted the fix-video-intelligence-test branch June 9, 2020 08:13
@tvalentyn
Copy link
Copy Markdown
Contributor

I filed https://issues.apache.org/jira/browse/BEAM-10229 - is it already fixed by this change?

@kamilwu kamilwu changed the title Fix VideoIntelligence IT tests [BEAM-10229] Fix VideoIntelligence IT tests Jun 10, 2020
@kamilwu
Copy link
Copy Markdown
Contributor Author

kamilwu commented Jun 15, 2020

I filed https://issues.apache.org/jira/browse/BEAM-10229 - is it already fixed by this change?

Yes, it is.

yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
VideoIntelligence IT tests use presence label annotations for comparing actual results to expected results, which is made available only when the client sets LabelDetectionConfig.model to “builtin/latest” in the request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants