AVRO-1749 Java: Introduce induce Maven plugin goal #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Dec 13, 2018
| File outputFile = new File(fileName); | ||
| outputFile.getParentFile().mkdirs(); | ||
| try { | ||
| PrintWriter writer = new PrintWriter(fileName, "UTF-8"); |
Contributor
There was a problem hiding this comment.
Can we use Try-With-Resource here: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
| } | ||
|
|
||
| private String parseClassName(String fileName) { | ||
| String indentifier = "java/"; |
Contributor
There was a problem hiding this comment.
Maybe make this a static final constant?
SingingBush
pushed a commit
to SingingBush/avro
that referenced
this pull request
Jun 29, 2023
Avro 1.9.0-SNAPSHOT, with jsr310 enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-1749
Maven plugin goal to induce Avro schemas and protocol from Java classes.
(this PR was previously #67)