AVRO-1762: Velocity custom objects #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this feature is really needed. |
Contributor
|
Can you rebase onto master? |
5d4e2e3 to
750b76c
Compare
Contributor
Author
Sure thing. Done! |
Fokko
reviewed
Jun 3, 2019
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Looks good, one minor comment. What do you think?
lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
Outdated
Show resolved
Hide resolved
It provides more flexibility when generating code with custom Velocity templates.
Rebased on master
Improved unit tests
velocityTools is now of type List<Object>
750b76c to
27cb0cf
Compare
Fokko
approved these changes
Jun 9, 2019
Fokko
pushed a commit
that referenced
this pull request
Jun 10, 2019
* AVRO-1762. Java: Put additional objects into Velocity template It provides more flexibility when generating code with custom Velocity templates. * AVRO-1762. Java: Put additional objects into Velocity template Rebased on master * AVRO-1762. Java: Put additional objects into Velocity template Improved unit tests * AVRO-1762: Velocity custom objects velocityTools is now of type List<Object> (cherry picked from commit a897c50)
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to Avro-1762 for more information.
Avro 1762 pull request rebased on master and with some tests improvements.
This PR is a rebased version of #71