ARROW-4444: [Testing] Add CSV test file for use by DataFusion unit tests and examples#1
Conversation
| @@ -0,0 +1,37 @@ | |||
| "Elgin, Scotland, the UK",57.653484,-3.335724 | |||
There was a problem hiding this comment.
Where does this file originate from?
There was a problem hiding this comment.
I'm trying to remember ... if I can't find it, I will download fresh from here:
https://simplemaps.com/data/world-cities
The free download here uses the Creative Commons Attribution License.
There was a problem hiding this comment.
Can you write a LICENSE file and remark that in there?
There was a problem hiding this comment.
@xhochy For now I removed the files that are not used, and I manually created a new uk_cities.csv with just two cities and looked up lat/lon online, so this is safe to merge.
Once the DataFusion donation is accepted I'll create some better test files and delete the trivial ones. I don't want to complicate the donation by doing that now and updating all the tests.
There was a problem hiding this comment.
@andygrove It's ok to have these files as long as the license is APL 2.0 compatible and mentioned correctly in LICENSE.
…e I can't trace where the original data came from
|
@xhochy I deleted all the files and started again. There is now a single generated file. I have updated my DataFusion tests and examples to use this file now. |
No description provided.