Skip to content

[Website]: Update to Jekyl 4.3.3 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 2 commits into from
Jan 6, 2024
Merged

[Website]: Update to Jekyl 4.3.3 #451

kou merged 2 commits into from
Jan 6, 2024

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 6, 2024

As suggested by @kou in #448 (comment) let's use the latest Jekyll so the docs build with the latest ruby version

Note that @bkmgit has another PR that updates all dependencies in #449

@alamb
Copy link
Contributor Author

alamb commented Jan 6, 2024

I tested this locally and it seems to work well

The only issue I saw was some new warnings about deprecation

eprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2) or calc($spacer / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
302 │ $headings-margin-bottom:      $spacer / 2 !default;
    │                               ^^^^^^^^^^^
    ╵
    /arrow-site/node_modules/bootstrap/scss/_variables.scss 302:31  @import
    bootstrap/scss/bootstrap.scss 9:9                               @import
    /arrow-site/css/main.scss 1:9                                   root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($input-padding-y, 2) or calc($input-padding-y / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
498 │ $input-height-inner-quarter:            add($input-line-height * .25em, $input-padding-y / 2) !default;
    │                                                                         ^^^^^^^^^^^^^^^^^^^^
    ╵
    /arrow-site/node_modules/bootstrap/scss/_variables.scss 498:73  @import
    bootstrap/scss/bootstrap.scss 9:9                               @import
    /arrow-site/css/main.scss 1:9                                   root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($custom-control-indicator-size, 2) or calc($custom-control-indicator-size / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
568 │ $custom-switch-indicator-border-radius:         $custom-control-indicator-size / 2 !default;
    │                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    /arrow-site/node_modules/bootstrap/scss/_variables.scss 568:49  @import
    bootstrap/scss/bootstrap.scss 9:9                               @import
    /arrow-site/css/main.scss 1:9                                   root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2) or calc($spacer / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
713 │ $nav-divider-margin-y:              $spacer / 2 !default;
    │                                     ^^^^^^^^^^^
    ╵
    /arrow-site/node_modules/bootstrap/scss/_variables.scss 713:37  @import
    bootstrap/scss/bootstrap.scss 9:9                               @import
    /arrow-site/css/main.scss 1:9                                   root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2) or calc($spacer / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
718 │ $navbar-padding-y:                  $spacer / 2 !default;
    │                                     ^^^^^^^^^^^
    ╵
    /arrow-site/node_modules/bootstrap/scss/_variables.scss 718:37  @import
    bootstrap/scss/bootstrap.scss 9:9                               @import
    /arrow-site/css/main.scss 1:9                                   root stylesheet
Warning: 64 repetitive deprecation warnings omitted.
Run in verbose mode to see all warnings.

This was referenced Jan 6, 2024
Closed
Closed
kou
kou approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit a195a9d into apache:main Jan 6, 2024
@bkmgit bkmgit mentioned this pull request Jan 7, 2024
Closed
@alamb alamb deleted the alamb/update_jekyl branch January 8, 2024 13:47
benknoble added a commit to benknoble/benknoble.github.io that referenced this pull request Apr 22, 2024
@benknoble
deps: update Jekyll
56cb259 
This updates Jekyll to include
jekyll/jekyll#9392.

Without this update, `make` produces

To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
jekyll 4.2.0 | Error:  undefined method `[]' for nil
/usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/logger.rb:384:in `level': undefined method `[]' for nil (NoMethodError)

    @level_override[Fiber.current] || @Level
                   ^^^^^^^^^^^^^^^
        from /usr/local/lib/ruby/gems/3.3.0/gems/jekyll-4.2.0/lib/jekyll/log_adapter.rb:45:in `adjust_verbosity'
        from /usr/local/lib/ruby/gems/3.3.0/gems/jekyll-4.2.0/lib/jekyll/configuration.rb:143:in `config_files'
        from /usr/local/lib/ruby/gems/3.3.0/gems/jekyll-4.2.0/lib/jekyll.rb:118:in `configuration'
        from /usr/local/lib/ruby/gems/3.3.0/gems/jekyll-4.2.0/lib/jekyll/command.rb:44:in `configuration_from_options'
        from /usr/local/lib/ruby/gems/3.3.0/gems/jekyll-4.2.0/lib/jekyll/commands/serve.rb:83:in `block (2 levels) in init_with_program'
        from /usr/local/lib/ruby/gems/3.3.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `block in execute'
        from /usr/local/lib/ruby/gems/3.3.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `each'
        from /usr/local/lib/ruby/gems/3.3.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `execute'
        from /usr/local/lib/ruby/gems/3.3.0/gems/mercenary-0.4.0/lib/mercenary/program.rb:44:in `go'
        from /usr/local/lib/ruby/gems/3.3.0/gems/mercenary-0.4.0/lib/mercenary.rb:21:in `program'
        from /usr/local/lib/ruby/gems/3.3.0/gems/jekyll-4.2.0/exe/jekyll:15:in `<top (required)>'
        from /usr/local/lib/ruby/gems/3.3.0/bin/jekyll:25:in `load'
        from /usr/local/lib/ruby/gems/3.3.0/bin/jekyll:25:in `<top (required)>'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/cli/exec.rb:58:in `load'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/cli/exec.rb:58:in `kernel_load'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/cli/exec.rb:23:in `run'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/cli.rb:451:in `exec'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/cli.rb:34:in `dispatch'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/cli.rb:28:in `start'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/bundler-2.5.4/exe/bundle:28:in `block in <top (required)>'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/friendly_errors.rb:117:in `with_friendly_errors'
        from /usr/local/Cellar/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/bundler-2.5.4/exe/bundle:20:in `<top (required)>'
        from /usr/local/opt/ruby/bin/bundle:25:in `load'
        from /usr/local/opt/ruby/bin/bundle:25:in `<main>'

Googling suggested that downgrading ruby would work, but Jekyll release
notes (and a hint from apache/arrow-site#451)
suggested the real fix: upgrade Jekyll.

The new warning about the csv module is waiting on a backport release
from Jekyll.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb @kou