fix(gcp): throw error instead of panicking if read pem fails#421
Merged
Conversation
tustvold
approved these changes
Jul 7, 2025
Contributor
|
It would be even better to have a test for this, but also not a requirement by any means |
crepererum
pushed a commit
to crepererum/arrow-rs-object-store
that referenced
this pull request
Jul 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #419
Rationale for this change
See issue
What changes are included in this PR?
Return a ReadPem error instead of panicking when the GCS service account key contains an invalid private key.
Are there any user-facing changes?
No