Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 9, 2026

Which issue does this PR close?

  • Closes #NNN.

Rationale for this change

Clippy is failiing on main after merging cfba3cc

Example: https://github.com/apache/arrow-rs/actions/runs/20865325961/job/59954918027

error: deref which would be done by auto-deref
   --> arrow-pyarrow/src/lib.rs:636:39
    |
636 |         Ok(Self(T::from_pyarrow_bound(&*value)?))
    |                                       ^^^^^^^ help: try: `&value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#explicit_auto_deref
    = note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]`

What changes are included in this PR?

Apply clippy fix

Are these changes tested?

Are there any user-facing changes?

@Jefffrey Jefffrey merged commit 7a4e639 into apache:main Jan 10, 2026
16 of 17 checks passed
Dandandan pushed a commit to Dandandan/arrow-rs that referenced this pull request Jan 15, 2026
# Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->

- Closes #NNN.

# Rationale for this change

Clippy is failiing on main after merging
apache@cfba3cc
- apache#8773

Example:
https://github.com/apache/arrow-rs/actions/runs/20865325961/job/59954918027

```
error: deref which would be done by auto-deref
   --> arrow-pyarrow/src/lib.rs:636:39
    |
636 |         Ok(Self(T::from_pyarrow_bound(&*value)?))
    |                                       ^^^^^^^ help: try: `&value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#explicit_auto_deref
    = note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]`
```

# What changes are included in this PR?
Apply clippy fix

# Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

# Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants