-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Arrow-avro Writer Dense Union support #8550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6357bda to
1940470
Compare
a2acad4 to
8bc38ca
Compare
8d936c8 to
b6bf021
Compare
mbrobbel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nathaniel-d-ef and @jecsand838
|
@mbrobbel Just a heads up that @nathaniel-d-ef is out of office until early next week. |
Thanks @jecsand838 -- to keep things moving do you think you would be able to implement the PR suggestions? I would normally do it myself, but I don't have the permissions to push to the elastiflow fork: https://github.com/elastiflow/arrow-rs |
|
Thanks @mbrobbel and @alamb - I’m fully AFK until next week. I’ll pass this
thread to my team to see if someone can tackle it before then.
…On Tue, Oct 7, 2025 at 20:27 Andrew Lamb ***@***.***> wrote:
*alamb* left a comment (apache/arrow-rs#8550)
<#8550 (comment)>
@mbrobbel <https://github.com/mbrobbel> Just a heads up that
@nathaniel-d-ef <https://github.com/nathaniel-d-ef> is out of office
until early next week.
Thanks @nathaniel-d-ef <https://github.com/nathaniel-d-ef> -- to keep
things moving do you think you would be able to implement the PR
suggestions? I would normally do it myself, but I don't have the
permissions to push to the elastiflow fork:
https://github.com/elastiflow/arrow-rs
—
Reply to this email directly, view it on GitHub
<#8550 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJ7GZK5BSIPPEOEV2CRNA5L3WQAZBAVCNFSM6AAAAACIHQMRT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNZYGA3TONZTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
Absolutely! Just pushed up those PR suggestions. |
mbrobbel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jecsand838!
|
woohoo! |
Which issue does this PR close?
Relates to:
#8348
#4886
Rationale for this change
This PR completes the efforts of @jecsand838, adding dense union support to the encoder side of the crate, along with four other minor extensions of existing time-related encoding.
Note: currently this PR is stacked behind #8546. Once that's merged this will be updated and will not include those changes.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Crate not yet public