arrow-ipc: Remove all abilities to preserve dict IDs #7940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tustvold @alamb @thinkharderdev @adriangb this one should be very uncontroversial and easy to review as it's just following through with the previously agreed upon deprecations. |
332ab3f to
510f8d5
Compare
510f8d5 to
411ef8d
Compare
alamb
approved these changes
Jul 17, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @brancz and @adriangb -- likewise this makes sense to me
cc @thinkharderdev @Dandandan @crepererum as I think your systems also use dict_id maybe in the past
crepererum
approved these changes
Jul 18, 2025
Contributor
|
Thanks again @brancz |
alamb
pushed a commit
that referenced
this pull request
Jul 22, 2025
…7968) # Which issue does this PR close? Closes #6356 # Rationale for this change Now that #7940 is merged, nothing useful can be done with the `dict_id` field, therefore, it is now safe to be removed from this requirement. This was also split out from: #7467 # What changes are included in this PR? No longer require the `dict_id` fields of two `Field`s of schemas being merged to be equal, as at this point the `dict_id` is only an IPC concern, and the fact that it is still in the struct definition is just legacy, marked for removal, we're just going through the proper procedure of deprecating and replacing the APIs that use it. # Are these changes tested? Tests passing. # Are there any user-facing changes? No API changes, just a behavior change, that was to be expected and desired due to the deprecations around the `dict_id` field. @alamb @adriangb @tustvold
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Does not yet close, but contributes towards:
dict_idequality in field merging #6356dict_idfromarrow_schema::field::Fieldand make dictionary IDs an internal implementation detail of flight encoding/decoding #5981Rationale for this change
See the above issues. And this is a follow up to
dict_id#6873This was also split out from: #7929
What changes are included in this PR?
This removes the API to allow preserving
dict_idset in theSchema'sFieldwithin arrow-ipc and arrow-flight. This is in an effort to remove thedict_idfield entirely and make it an IPC/flight-only concern.Are these changes tested?
Yes, all existing tests continue to pass.
Are there any user-facing changes?
Yes, these previously (in 54.0.0) deprecated functions/fields are removed:
arrow_ipc::DictionaryTracker.set_dict_idarrow_ipc::DictionaryTracker::new_with_preserve_dict_idarrow_ipc::IpcWriteOptions.with_preserve_dict_idarrow_ipc::IpcWriteOptions.preserve_dict_id(function and field)arrow_ipc::schema_to_fbarrow_ipc::schema_to_bytes