Skip to content

Conversation

@rluvaton
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

can_rank should be next to the actual implementation.
I'm in a middle of adding support for ranking booleans and was not aware of this function

Are there any user-facing changes?

No, as this function was not public

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @rluvaton

@alamb alamb merged commit 63899b7 into apache:main Dec 26, 2024
17 checks passed
CurtHagenlocher pushed a commit to CurtHagenlocher/arrow-rs that referenced this pull request Dec 28, 2024
svencowart pushed a commit to elastiflow/arrow-rs that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants