Skip to content

Make ArrayData.align_buffers align child data buffers recursively#6462

Merged
tustvold merged 1 commit intoapache:masterfrom
EnricoMi:align-child-data-buffers
Sep 27, 2024
Merged

Make ArrayData.align_buffers align child data buffers recursively#6462
tustvold merged 1 commit intoapache:masterfrom
EnricoMi:align-child-data-buffers

Conversation

@EnricoMi
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #6461.

Rationale for this change

See #6461.

What changes are included in this PR?

Method ArrayData.align_buffers recursively calls align_buffers on all child data.

Are there any user-facing changes?

None except for struct data types being supported from now on. In code documentation is amended.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 26, 2024
@EnricoMi
Copy link
Copy Markdown
Contributor Author

CC @tustvold

Copy link
Copy Markdown
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArrayData.align_buffers should support Struct data type / child data

2 participants