feat(object_store): parse well-known storage urls#3327
feat(object_store): parse well-known storage urls#3327tustvold merged 9 commits intoapache:masterfrom
Conversation
tustvold
left a comment
There was a problem hiding this comment.
I think it would be a better UX for this to return an error if it doesn't recognise the URL.
Perhaps we could stash any error on the Builder and return it during build?
|
Benchmark runs are scheduled for baseline = 75ef138 and contender = 19f8e8c. 19f8e8c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
* feat(object_store): add url parsing to azure builder * feat(object_store): add url parsing to aws builder * feat(object_store): add url parsing to gcs builder * feat(object_store): parse gcs service account from env * fix: typo * docs(object_store): fix example / template urls * feat(object_store): parse S3 virtually hosted urls * refactor: raise url parsing errors on build * fix: properly set virtual_hosted_style_request in url parsing
Which issue does this PR close?
Closes #2304
cc @tustvold
Rationale for this change
See discussion in #2304 - in a nutshell, accessible storage locations can be described by various url formats (especially for azure storage) and we aim to provide url parsing centrally since it is a very common task to perform in consuming applications.
What changes are included in this PR?
Added new
with_urlmemebrs to aws, gcp, and azure builders to be used via:Are there any user-facing changes?
yes.