chore(ci): Add CUDA runner for testing device extension#490
Merged
paleolimbot merged 14 commits intomainfrom Jun 25, 2024
Merged
chore(ci): Add CUDA runner for testing device extension#490paleolimbot merged 14 commits intomainfrom
paleolimbot merged 14 commits intomainfrom
Conversation
Member
|
Might need INFRA to enable the CUDA runners on this repo? Not sure who controls that |
paleolimbot
added a commit
that referenced
this pull request
Jun 4, 2024
…tion to use the driver API (#488) Closes #246. This PR doesn't change much about the existing implementation (and I think there are some things that need to be changed!), it just eliminates the dependency on the runtime library. The driver API is a better fit here anyway since we're doing very low-level things! This isn't tested in CI yet (working on that here: #490 ).
f39bee7 to
4273353
Compare
c222516 to
cac3e98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the INFRA-provided runner
["self-hosted", "cuda"]so that PRs that modify CUDA code get better CI feedback (before this, the extension pretty much was only ever built on my local setup).The self-hosted runner is running an older linux than the usual
ubuntu-latest, so a few modifications were needed to reflect compiler warning policies. The cache key we were using for Arrow C++ is also no longer sufficient for the device workflow because a cache restore results in an unusable Arrow C++ static library on the self-hosted runner. This shouldn't be necessary for much longer (just until Arrow C++-dependent tests are factored out and run separately).