fix(arrow/cdata): Handle errors to prevent panic#614
Merged
zeroshade merged 1 commit intoapache:mainfrom Jan 14, 2026
Merged
Conversation
zeroshade
requested changes
Dec 19, 2025
Member
zeroshade
left a comment
There was a problem hiding this comment.
Looks good, can you add a test for this please?
zeroshade
approved these changes
Dec 22, 2025
Member
|
Thanks! Assuming no issues in CI i'll merge this |
Member
|
Looks like you have some test failures here |
Contributor
Author
|
@zeroshade please review it |
Contributor
Author
|
I have resubmitted the code based on the error messages, and the tests passed successfully on my local mechine. |
Member
|
@xiaocai2333 looks like there's a memory leak found by the leak sanitizer that needs to be addressed. I can poke at it tomorrow if you need help tracking it down. Specifically, the 48 bytes leaks are likely ArrowSchema objects that aren't getting freed (probably children in a nested test) |
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
b9d4cd3 to
557f8a0
Compare
Contributor
Author
|
@zeroshade hi, I have fixed the memory leak and verified it locally. Could you please approve this to run the CI workflows? |
zeroshade
approved these changes
Jan 14, 2026
chyezh
added a commit
to chyezh/arrow
that referenced
this pull request
Apr 1, 2026
Port of apache/arrow-go#614 to v17. When importing a C Data Interface array with children (e.g., a record batch as a struct array), `doImport()` had a deferred `C.free(imp.arr)` that fired when `imp.data == nil` (import error). For child importers, `imp.arr` points into the parent's contiguous SmallVector allocation (an interior pointer), not a standalone malloc'd pointer. Calling `C.free()` on this interior pointer triggers ASan bad-free and causes heap corruption in production. Fix: 1. Remove the `C.free` defer from `doImport()` entirely. 2. Introduce `importAllocator.forceRelease()` which always frees the root-level malloc'd ArrowArray (via `importAllocator.arr`), never child interior pointers. Uses atomic CAS to ensure single execution. 3. In `doImportArr`, call `forceRelease()` on error or when bufCount==0. 4. Propagate errors from `importChild()` in STRUCT, DENSE_UNION, and SPARSE_UNION cases (previously silently ignored). 5. Release already-imported child data on error in `doImport()`. Ref: apache/arrow-go#613, apache/arrow-go#614 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: chyezh <chyezh@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes: #613
What changes are included in this PR?
Return error correctly.
Are these changes tested?
Yes
Are there any user-facing changes?
No