fix: list_columns.parquet testing#378
Merged
zeroshade merged 2 commits intoapache:mainfrom May 20, 2025
Merged
Conversation
f94cd32 to
68b7e59
Compare
MetalBlueberry
commented
May 14, 2025
| require.Equal(t, records[j][i], "") | ||
| continue | ||
| } | ||
| require.Equal(t, records[j][i], vals.ValueStr(j)) |
Contributor
Author
There was a problem hiding this comment.
It panics here
Contributor
Author
|
I found a change that may be the root cause for this issue. Calling ResetValues is not the same as Reset. Which seems to leave the recordReader in the wrong state |
record reader needs to move forward after reading data to not attempt to read the same portion.
zeroshade
approved these changes
May 20, 2025
zeroshade
pushed a commit
that referenced
this pull request
Jun 17, 2025
add list_columns.parquet testing. `rr.Next()` is returning true when we've already reached the end of the file. This leads to a panic later on - Test that proves list_columns.parquet is not working as expected. - Use known path for partquet_testing if var is not defined. This ensures test can be run as usual but still enables custom locations for parquet_test_data. It also guarantees failure if not run correctly. That is the goal of the PR no? (cherry picked from commit 60e36a4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
add list_columns.parquet testing.
rr.Next()is returning true when we've already reached the end of the file. This leads to a panic later onWhat changes are included in this PR?
Are these changes tested?
That is the goal of the PR
Are there any user-facing changes?
no?