fix(arrow/cdata): move headers into parent Go package#251
Merged
zeroshade merged 1 commit intoapache:mainfrom Jan 16, 2025
Merged
fix(arrow/cdata): move headers into parent Go package#251zeroshade merged 1 commit intoapache:mainfrom
zeroshade merged 1 commit intoapache:mainfrom
Conversation
lidavidm
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
fixes #244, also addresses the issue discovered by apache/arrow-adbc#2449 (comment)
What changes are included in this PR?
Moving the
abi.handhelpers.hheaders up into the parentcdataGo package. Also addingstatic inlineto the helper methods to fix undefined symbol issues when building withCGO_CFLAGS=-g3.Are these changes tested?
Yes, existing unit tests will cover the changes.
Are there any user-facing changes?
No