Skip to content

Please move header files from arrow/cdata/arrow/c into the parent Go package #244

@folliehiyuki

Description

@folliehiyuki

Describe the bug, including details regarding any error messages, version, and platform.

arrow-go fails to build if it's being vendored by another Go module. This is because all non-go files not being in a go package will be removed by go mod vendor. Building another Go module vendoring arrow-go will leads to the below error (the arrow/c/ directory was stripped in the vendoring process):

# github.com/apache/arrow-go/v18/arrow/cdata
vendor/github.com/apache/arrow-go/v18/arrow/cdata/cdata.go:25:11: fatal error: arrow/c/abi.h: No such file or directory
   25 | // #include "arrow/c/abi.h"
      |           ^~~~~~~~~~~~~~~
compilation terminated.

For now, I added -I/usr/include CFLAGS to my build to search for system's apache-arrow header files. They seem to be identical to the files in arrow/cdata/arrow/c.

Ref: golang/go#26366

Component(s)

Other

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions