ARROW-961: [Python] Rename InMemoryOutputStream to BufferOutputStream #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6f3acbf17b68c13f849f15c193700df977377237
Change-Id: I29a3c344300ae785a6e1a6cf9c41df33328d338e
xhochy
reviewed
May 15, 2017
python/pyarrow/__init__.py
Outdated
| # ---------------------------------------------------------------------- | ||
| # 0.4.0 deprecations | ||
|
|
||
| InMemoryOutputStream = BufferOutputStream |
Member
There was a problem hiding this comment.
Can we print a deprecation warning here?
Member
Author
There was a problem hiding this comment.
Totally. I added deprecation warnings for the other recently-renamed classes and a test suite to check that they still work properly
Change-Id: Ib19b789a6d7d34011d62caab719d89b7c5af7190
Member
Author
|
Here's the appveyor build: https://ci.appveyor.com/project/wesm/arrow/build/1.0.441 |
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
Better API naming consistency with C++ Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#690 from wesm/ARROW-961 and squashes the following commits: 85b352c [Wes McKinney] Add more graceful deprecation warnings for renamed classes, test suite 69a99cd [Wes McKinney] Fix Cython compilation a15910a [Wes McKinney] Rename InMemoryOutputStream to BufferOutputStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better API naming consistency with C++