ARROW-1017: [Python] Fix memory leaks in conversion to pandas.DataFrame #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ARRAY_OWNDATA Change-Id: I22b284add9268c48278e56e54f1b8be0ab6a2593
Member
Author
|
This is a serious enough problem that I think we should do a 0.3.1. What do you think? |
Contributor
|
Does it makes sense to follow up with a C++ test that can verify specific refcounts? |
Member
Author
|
Sure, it would be a bit of work but a good idea. I put the test script here at least to eyeball whether there is a memory leak |
Member
Author
|
see ARROW-1026 |
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
Notes: * `PyList_Append` increments ref count, so new objects must be DECREF'd after being inserted * `PyArray_SimpleNewFromDescr` does not set `NPY_ARRAY_OWNDATA`, neither does `NewFromDescr` Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#685 from wesm/ARROW-1017 and squashes the following commits: 8459123 [Wes McKinney] Fix memory leak caused by list append ref count, lack of setting NPY_ARRAY_OWNDATA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
PyList_Appendincrements ref count, so new objects must be DECREF'd after being insertedPyArray_SimpleNewFromDescrdoes not setNPY_ARRAY_OWNDATA, neither doesNewFromDescr