-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-8237: [Python][Documentation] Review Python developer documentation, add Dockerfile showing minimal source build with conda and pip/virtualenv #6842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@JacekPliszka take a look at the packages being installed and the build_venv.sh script, I'm able to build the project fine with pip and virtualenv / no conda on Fedora 31. If you are fail to follow the script it may give clues about what is wrong with your environment. |
|
thank you, this works for me. I just have 2 minor corrections - fedora uses podman and selinux blocks runing the scripts. So I would suggest: a) adding To Dockerfile.fedora - alternative would be adding --security-opt label=disable to podman run options - whatever you prefer b) run with Changes are here |
|
Did you find out what's wrong with your host OS? i.e. running the build steps outside of a container environment. |
No. When I run it directly on OS it worked too. |
|
Added some corrections to my branch - waiting for tests to finish - when they are OK I will raise pull request. |
|
Alright. I'll go ahead and merge this. I'm not sure about the docker/podman thing, this seems like an extra complication. |
|
+1 |
On Fedora/RH docker is replaced by podman so if you want something to be working out of box then podman should be used. Using docker requires installing docker CE and downgrading from cgroups v2 to cgroups v1. I do not like having 2 tools instead of one but I believe it is better to have it like this. Maybe comment should be added that docker config is the base one and in case of problems user should first try docker instead of podman to ensure issues are not podman related. |
|
I've created pull request with my changes I |
This provides Dockerfile setups to build both with Fedora 31 (very recent) and Ubuntu 18.04, both with conda and pip/virtualenv methods
I made the Python developer instructions a bit more minimal. It's unclear that the average developer needs to build Gandiva and Flight, for example. It's fairly clear how to enable these optional components if they are desired.