Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Apr 5, 2020

This provides Dockerfile setups to build both with Fedora 31 (very recent) and Ubuntu 18.04, both with conda and pip/virtualenv methods

I made the Python developer instructions a bit more minimal. It's unclear that the average developer needs to build Gandiva and Flight, for example. It's fairly clear how to enable these optional components if they are desired.

@wesm
Copy link
Member Author

wesm commented Apr 5, 2020

@JacekPliszka take a look at the packages being installed and the build_venv.sh script, I'm able to build the project fine with pip and virtualenv / no conda on Fedora 31. If you are fail to follow the script it may give clues about what is wrong with your environment.

@github-actions
Copy link

github-actions bot commented Apr 5, 2020

@JacekPliszka
Copy link
Contributor

JacekPliszka commented Apr 5, 2020

@wesm

thank you, this works for me.

I just have 2 minor corrections - fedora uses podman and selinux blocks runing the scripts.

So I would suggest:

a) adding

RUN mkdir /io

COPY build_conda.sh /io/
COPY build_venv.sh /io/

To Dockerfile.fedora - alternative would be adding --security-opt label=disable to podman run options - whatever you prefer

b) run with

podman build  -t arrow_fedora_minimal -f Dockerfile.fedora
podman run --rm -i -t  arrow_fedora_minimal /io/build_venv.sh

Changes are here

https://github.com/JacekPliszka/arrow/tree/ARROW-8237

@wesm
Copy link
Member Author

wesm commented Apr 5, 2020

Did you find out what's wrong with your host OS? i.e. running the build steps outside of a container environment.

@JacekPliszka
Copy link
Contributor

Did you find out what's wrong with your host OS? i.e. running the build steps outside of a container environment.

No. When I run it directly on OS it worked too.

@JacekPliszka
Copy link
Contributor

Added some corrections to my branch - waiting for tests to finish - when they are OK I will raise pull request.

@wesm
Copy link
Member Author

wesm commented Apr 5, 2020

Alright. I'll go ahead and merge this.

I'm not sure about the docker/podman thing, this seems like an extra complication.

@wesm
Copy link
Member Author

wesm commented Apr 5, 2020

+1

@wesm wesm closed this in 10b0ecc Apr 5, 2020
@wesm wesm deleted the ARROW-8237 branch April 5, 2020 20:46
@JacekPliszka
Copy link
Contributor

Alright. I'll go ahead and merge this.

I'm not sure about the docker/podman thing, this seems like an extra complication.

On Fedora/RH docker is replaced by podman so if you want something to be working out of box then podman should be used. Using docker requires installing docker CE and downgrading from cgroups v2 to cgroups v1.

I do not like having 2 tools instead of one but I believe it is better to have it like this.

Maybe comment should be added that docker config is the base one and in case of problems user should first try docker instead of podman to ensure issues are not podman related.

@JacekPliszka
Copy link
Contributor

I've created pull request with my changes

#6845

I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants